| Summary: | Regression: :after content can fail to repaint borders | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Philip Rogers <pdr> | ||||||||
| Component: | New Bugs | Assignee: | Philip Rogers <pdr> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, d-r, esprehn+autocc, fmalita, glenn, kling, kondapallykalyan, schenney | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 212913 [details]
Patch
Comment on attachment 212913 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212913&action=review r=me, great find! > Source/WebCore/rendering/RenderElement.cpp:300 > - return diff == StyleDifferenceRepaint || (diff == StyleDifferenceRepaintIfText && hasImmediateNonWhitespaceTextChild()); > + return diff == StyleDifferenceRepaint || (diff == StyleDifferenceRepaintIfText && hasImmediateNonWhitespaceTextChildOrBorderOrOutline()); The name StyleDifferenceRepaintIfText is no longer entirely accurate. StyleDifferenceRepaintIfTextOrBorderOrOutline? :| Created attachment 212933 [details]
Patch
Comment on attachment 212933 [details]
Patch
Thanks for the quick review! I updated the enum value to reflect what it actually does (StyleDifferenceRepaintIfTextOrBorderOrOutline).
Off to the CQ for you, patch.
Comment on attachment 212933 [details] Patch Clearing flags on attachment: 212933 Committed r156619: <http://trac.webkit.org/changeset/156619> All reviewed patches have been landed. Closing bug. |
Created attachment 212912 [details] Testcase wkrev.com/150259 introduced a regression where :after content with borders or outlines can fail to repaint correctly. Patch forthcoming.