Bug 122065

Summary: Get rid of the AlreadyInJSStack recoveries since they are totally redundant with the DisplacedInJSStack recoveries
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, buildbot, commit-queue, eflews.bot, ggaren, gyuyoung.kim, mark.lam, mhahnenberg, msaboff, oliver, rakuco, rego+ews, rniwa, sam, webkit-ews, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 122024    
Attachments:
Description Flags
the patch
oliver: review+, webkit-ews: commit-queue-
the patch
mhahnenberg: review+, webkit-ews: commit-queue-
patch for landing
none
patch for landing none

Description Filip Pizlo 2013-09-28 10:51:04 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2013-09-30 11:48:50 PDT 
Created attachment 213018 [details]
the patch
Comment 2 WebKit Commit Bot 2013-09-30 11:50:59 PDT 
Attachment 213018 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/Target.pri', u'Source/JavaScriptCore/bytecode/CodeOrigin.h', u'Source/JavaScriptCore/bytecode/ValueRecovery.cpp', u'Source/JavaScriptCore/bytecode/ValueRecovery.h', u'Source/JavaScriptCore/dfg/DFGFixupPhase.cpp', u'Source/JavaScriptCore/dfg/DFGJITCode.cpp', u'Source/JavaScriptCore/dfg/DFGNode.h', u'Source/JavaScriptCore/dfg/DFGOSREntrypointCreationPhase.cpp', u'Source/JavaScriptCore/dfg/DFGOSRExitCompiler32_64.cpp', u'Source/JavaScriptCore/dfg/DFGOSRExitCompiler64.cpp', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h', u'Source/JavaScriptCore/dfg/DFGValueSource.h', u'Source/JavaScriptCore/dfg/DFGVariableEventStream.cpp', u'Source/JavaScriptCore/interpreter/Register.h', u'Source/JavaScriptCore/runtime/Arguments.cpp', u'Source/JavaScriptCore/runtime/Arguments.h']" exit_code: 1
Source/JavaScriptCore/bytecode/CodeOrigin.h:100:  Please declare integral type bitfields with either signed or unsigned.  [runtime/bitfields] [5]
Source/JavaScriptCore/bytecode/ValueRecovery.h:249:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Early Warning System Bot 2013-09-30 11:55:36 PDT 
Comment on attachment 213018 [details]
the patch

Attachment 213018 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/2815124
Comment 4 Early Warning System Bot 2013-09-30 11:56:54 PDT 
Comment on attachment 213018 [details]
the patch

Attachment 213018 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/2755145
Comment 5 Build Bot 2013-09-30 12:04:58 PDT 
Comment on attachment 213018 [details]
the patch

Attachment 213018 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/2818099
Comment 6 EFL EWS Bot 2013-09-30 12:13:50 PDT 
Comment on attachment 213018 [details]
the patch

Attachment 213018 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/2774129
Comment 7 Build Bot 2013-09-30 12:13:56 PDT 
Comment on attachment 213018 [details]
the patch

Attachment 213018 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/2761150
Comment 8 EFL EWS Bot 2013-09-30 12:15:53 PDT 
Comment on attachment 213018 [details]
the patch

Attachment 213018 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/2817114
Comment 9 Filip Pizlo 2013-09-30 12:32:47 PDT 
Created attachment 213022 [details]
the patch
Comment 10 WebKit Commit Bot 2013-09-30 12:34:59 PDT 
Attachment 213022 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/Target.pri', u'Source/JavaScriptCore/bytecode/CodeOrigin.h', u'Source/JavaScriptCore/bytecode/ValueRecovery.cpp', u'Source/JavaScriptCore/bytecode/ValueRecovery.h', u'Source/JavaScriptCore/dfg/DFGFixupPhase.cpp', u'Source/JavaScriptCore/dfg/DFGJITCode.cpp', u'Source/JavaScriptCore/dfg/DFGNode.h', u'Source/JavaScriptCore/dfg/DFGOSREntrypointCreationPhase.cpp', u'Source/JavaScriptCore/dfg/DFGOSRExitCompiler32_64.cpp', u'Source/JavaScriptCore/dfg/DFGOSRExitCompiler64.cpp', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h', u'Source/JavaScriptCore/dfg/DFGValueSource.h', u'Source/JavaScriptCore/dfg/DFGVariableEventStream.cpp', u'Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp', u'Source/JavaScriptCore/interpreter/Register.h', u'Source/JavaScriptCore/runtime/Arguments.cpp', u'Source/JavaScriptCore/runtime/Arguments.h']" exit_code: 1
Source/JavaScriptCore/bytecode/CodeOrigin.h:100:  Please declare integral type bitfields with either signed or unsigned.  [runtime/bitfields] [5]
Source/JavaScriptCore/bytecode/ValueRecovery.h:249:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 Early Warning System Bot 2013-09-30 12:50:03 PDT 
Comment on attachment 213022 [details]
the patch

Attachment 213022 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/2815134
Comment 12 Michael Saboff 2013-09-30 12:50:38 PDT 
Comment on attachment 213022 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213022&action=review

> Source/JavaScriptCore/ChangeLog:18
> +        after the forward exit are MovHints or other tnings that the OSR exit compiler can

Typo "things"

> Source/JavaScriptCore/ChangeLog:28
> +        that the solution is to rationalize how we choose the speculation direciton for a

typo "direction"
Comment 13 Mark Hahnenberg 2013-09-30 12:50:53 PDT 
Comment on attachment 213022 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213022&action=review

r=me + style bot stuff

>> Source/JavaScriptCore/ChangeLog:18
>> +        after the forward exit are MovHints or other tnings that the OSR exit compiler can
> 
> Typo "things"

s/tnings/things

> Source/JavaScriptCore/ChangeLog:30
> +        speculation direction of the node for which it is doing a conversion. Since SetLocal's

s/SetLocal's/SetLocals
Comment 14 Filip Pizlo 2013-09-30 12:52:46 PDT 
Created attachment 213028 [details]
patch for landing
Comment 15 Filip Pizlo 2013-09-30 13:14:41 PDT 
Created attachment 213031 [details]
patch for landing
Comment 16 WebKit Commit Bot 2013-09-30 13:17:09 PDT 
Attachment 213031 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/Target.pri', u'Source/JavaScriptCore/bytecode/ValueRecovery.cpp', u'Source/JavaScriptCore/bytecode/ValueRecovery.h', u'Source/JavaScriptCore/dfg/DFGFixupPhase.cpp', u'Source/JavaScriptCore/dfg/DFGJITCode.cpp', u'Source/JavaScriptCore/dfg/DFGNode.h', u'Source/JavaScriptCore/dfg/DFGOSREntrypointCreationPhase.cpp', u'Source/JavaScriptCore/dfg/DFGOSRExitCompiler32_64.cpp', u'Source/JavaScriptCore/dfg/DFGOSRExitCompiler64.cpp', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h', u'Source/JavaScriptCore/dfg/DFGValueSource.h', u'Source/JavaScriptCore/dfg/DFGVariableEventStream.cpp', u'Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp', u'Source/JavaScriptCore/interpreter/Register.h', u'Source/JavaScriptCore/runtime/Arguments.cpp', u'Source/JavaScriptCore/runtime/Arguments.h']" exit_code: 1
Source/JavaScriptCore/bytecode/ValueRecovery.h:249:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 17 Filip Pizlo 2013-09-30 13:37:45 PDT 
Landed in http://trac.webkit.org/changeset/156677