Bug 122053

Summary: filter: drop-shadow doesnot support viewport units
Product: WebKit Reporter: gur.trio
Component: CSSAssignee: gur.trio
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, commit-queue, darin, esprehn+autocc, glenn, macpherson, menard
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Test case for filter: drop-shadow
none
Patch none

gur.trio
Reported 2013-09-28 00:50:05 PDT
filter: drop-shadow doesnot support viewport units
Attachments
Test case for filter: drop-shadow (323 bytes, text/html)
2013-09-28 00:50 PDT, gur.trio 		no flags
Details
Patch (11.83 KB, patch)
2013-09-28 01:22 PDT, gur.trio 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
gur.trio
Comment 1 2013-09-28 00:50:51 PDT
Created attachment 212883 [details] Test case for filter: drop-shadow
gur.trio
Comment 2 2013-09-28 01:22:39 PDT
Created attachment 212885 [details] Patch
Darin Adler
Comment 3 2013-09-28 08:48:23 PDT
Comment on attachment 212885 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212885&action=review > Source/WebCore/css/StyleResolver.cpp:3877 > + if (item->x->isViewportPercentageLength()) > + x = viewportPercentageValue(*item->x, x); Maybe we should have a function that does this dance. I have noticed that we have to repeat this idiom at every call site. If the inline call to isViewportPercentageLength is important for performance, we can make the function do it inline. I’d want to go back and do this for as many of the places we use viewportPercentageValue as possible. I don’t like repetitive idioms like this one when they are unnecessary.
WebKit Commit Bot
Comment 4 2013-09-28 09:12:47 PDT
Comment on attachment 212885 [details] Patch Clearing flags on attachment: 212885 Committed r156606: <http://trac.webkit.org/changeset/156606>
WebKit Commit Bot
Comment 5 2013-09-28 09:12:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.