Summary: | REGRESSION(r156546): media/video-no-audio.html broken | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||||
Component: | Media | Assignee: | Jer Noble <jer.noble> | ||||||||||
Status: | RESOLVED CONFIGURATION CHANGED | ||||||||||||
Severity: | Normal | CC: | ahmad.saleem792, buildbot, commit-queue, eric.carlson, glenn, jacob_uphoff, rniwa, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | 122021, 122043, 122111 | ||||||||||||
Bug Blocks: | |||||||||||||
Attachments: |
|
Description
Jer Noble
2013-09-27 22:15:40 PDT
Created attachment 212877 [details]
Patch
Tests will continue to fail until the fix for bug #122021 is landed. Rather, till bug #122043 is landed. Comment on attachment 212877 [details] Patch Attachment 212877 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/2657372 New failing tests: media/controls-strict.html media/controls-styling-strict.html media/audio-controls-rendering.html media/click-volume-bar-not-pausing.html fast/hidpi/video-controls-in-hidpi.html media/controls-without-preload.html media/media-controls-clone.html fast/layers/video-layer.html media/controls-after-reload.html Created attachment 212878 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 212877 [details] Patch Attachment 212877 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/2651351 New failing tests: media/controls-strict.html media/controls-styling-strict.html media/audio-controls-rendering.html media/click-volume-bar-not-pausing.html fast/hidpi/video-controls-in-hidpi.html media/controls-without-preload.html media/media-controls-clone.html fast/layers/video-layer.html media/controls-after-reload.html Created attachment 212879 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 212877 [details] Patch Attachment 212877 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/2657393 New failing tests: media/controls-strict.html media/controls-styling-strict.html media/audio-controls-rendering.html media/click-volume-bar-not-pausing.html fast/hidpi/video-controls-in-hidpi.html media/controls-without-preload.html media/media-controls-clone.html fast/layers/video-layer.html media/controls-after-reload.html Created attachment 212881 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 212877 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212877&action=review > Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:474 > + handleAudioTrackChange: function(event) > + { > + this.updateHasAudio(); > + }, > + > + handleAudioTrackAdd: function(event) > + { > + this.updateHasAudio(); > + }, > + > + handleAudioTrackRemove: function(event) > + { > + this.updateHasAudio(); > + }, Why not have a singe event handler for all three events, so each of these does the same thing? (In reply to comment #10) > (From update of attachment 212877 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=212877&action=review > > > Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:474 > > + handleAudioTrackChange: function(event) > > + { > > + this.updateHasAudio(); > > + }, > > + > > + handleAudioTrackAdd: function(event) > > + { > > + this.updateHasAudio(); > > + }, > > + > > + handleAudioTrackRemove: function(event) > > + { > > + this.updateHasAudio(); > > + }, > > Why not have a singe event handler for all three events, so each of these does the same thing? Sure; that just means registering with updateHasAudio, rather than each individual function. Committed r156656: <http://trac.webkit.org/changeset/156656> This broke several other tests, and Jer is not on IRC, so I'm rolling out. Re-opened since this is blocked by bug 122111 Rolled out in <http://trac.webkit.org/changeset/156661>. Broken tests: <http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r156656%20(13365)/results.html>. Not sure about the one that timed out - it never failed before, but it's not clear how it could possibly be affected. This test seems to be removed in following commit: https://github.com/WebKit/WebKit/commit/a39bd42ad87d82a3bea0fa6eac107376a973cf7c Nothing to do here. |