Bug 122048 – WebKit fails to build with newer versions of clang

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Mark Rowe (bdash)]

Most of the WebKit projects fail to build in various ways with newer versions of clang.

<rdar://problem/15079224>

[Mark Rowe (bdash)]

I'm going to abuse the process a little bit and use this single bug for six patches: one to fix an issue with the Xcode configuration that causes failures in multiple projects, and five other patches to fix issues in individual projects.

[Mark Rowe (bdash)]

Created attachment 212864 [details]
Fix an .xcconfig issue that affects several projects

[Mark Rowe (bdash)]

Created attachment 212865 [details]
Fix WTF

[Mark Rowe (bdash)]

Created attachment 212866 [details]
Fix JavaScriptCore

[Mark Rowe (bdash)]

Created attachment 212867 [details]
Fix WebKit

[WebKit Commit Bot]

Attachment 212864 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Configurations/WebCore.xcconfig', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/Configurations/DebugRelease.xcconfig', u'Source/WebKit/mac/Configurations/WebKit.xcconfig', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Configurations/BaseTarget.xcconfig', u'Source/WebKit2/Configurations/DebugRelease.xcconfig', u'Tools/ChangeLog', u'Tools/DumpRenderTree/mac/Configurations/Base.xcconfig', u'Tools/DumpRenderTree/mac/Configurations/BaseTarget.xcconfig', u'Tools/DumpRenderTree/mac/Configurations/DebugRelease.xcconfig', u'Tools/DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig', u'Tools/DumpRenderTree/mac/Configurations/ImageDiff.xcconfig', u'Tools/DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig', u'Tools/WebKitTestRunner/Configurations/Base.xcconfig', u'Tools/WebKitTestRunner/Configurations/BaseTarget.xcconfig', u'Tools/WebKitTestRunner/Configurations/DebugRelease.xcconfig', u'Tools/WebKitTestRunner/Configurations/InjectedBundle.xcconfig', u'Tools/WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig']" exit_code: 1
Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebKit/mac/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 4 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Mark Rowe (bdash)]

Created attachment 212868 [details]
Fix WebKit2

[Mark Rowe (bdash)]

Created attachment 212869 [details]
Fix WebCore

[WebKit Commit Bot]

Attachment 212865 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/DateMath.cpp', u'Source/WTF/wtf/FastMalloc.cpp', u'Source/WTF/wtf/TCSystemAlloc.cpp', u'Source/WTF/wtf/dtoa.cpp']" exit_code: 1
Source/WTF/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Attachment 212866 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/interpreter/Interpreter.cpp', u'Source/JavaScriptCore/parser/SourceProvider.cpp', u'Source/JavaScriptCore/runtime/GCActivityCallback.cpp', u'Source/JavaScriptCore/runtime/JSCJSValue.cpp', u'Source/JavaScriptCore/runtime/JSString.cpp']" exit_code: 1
Source/JavaScriptCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Attachment 212867 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/mac/Carbon/HIWebView.mm', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/History/BinaryPropertyList.cpp', u'Source/WebKit/mac/Misc/WebIconDatabase.mm', u'Source/WebKit/mac/Plugins/WebBaseNetscapePluginView.mm', u'Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm']" exit_code: 1
Source/WebKit/mac/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Attachment 212868 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/VisitedLinkTable.cpp', u'Source/WebKit2/UIProcess/Plugins/mac/PluginInfoStoreMac.mm', u'Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm', u'Source/WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm', u'Source/WebKit2/WebProcess/WebPage/FindController.cpp', u'Source/WebKit2/WebProcess/WebPage/WebBackForwardListProxy.cpp']" exit_code: 1
Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Attachment 212869 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/indexeddb/IDBIndex.cpp', u'Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp', u'Source/WebCore/Modules/webaudio/AudioContext.cpp', u'Source/WebCore/Modules/webaudio/ScriptProcessorNode.cpp', u'Source/WebCore/Modules/webdatabase/SQLResultSet.cpp', u'Source/WebCore/Modules/webdatabase/SQLTransactionBackend.cpp', u'Source/WebCore/Modules/websockets/WebSocketHandshake.cpp', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/css/CSSGrammar.y.in', u'Source/WebCore/html/track/TextTrackCue.cpp', u'Source/WebCore/loader/TextResourceDecoder.cpp', u'Source/WebCore/page/ContentSecurityPolicy.cpp', u'Source/WebCore/page/ContentSecurityPolicy.h', u'Source/WebCore/page/DOMSecurityPolicy.cpp', u'Source/WebCore/page/DOMSecurityPolicy.h', u'Source/WebCore/page/animation/CSSPropertyAnimation.cpp', u'Source/WebCore/platform/mac/DisplaySleepDisabler.cpp', u'Source/WebCore/platform/mac/WebCoreFullScreenWarningView.mm', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayerCompositor.cpp', u'Source/WebCore/svg/SVGAnimatedAngle.cpp', u'Source/WebCore/svg/SVGUseElement.cpp', u'Source/WebCore/xml/XPathStep.cpp']" exit_code: 1
Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 212869 [details]
Fix WebCore

Attachment 212869 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/2648302

New failing tests:
http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url.html
http/tests/security/contentSecurityPolicy/script-src-none-inline-event.html
inspector/debugger/debugger-pause-on-blocked-script-url.html
http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy.html
http/tests/security/contentSecurityPolicy/javascript-url-blocked.html
inspector/debugger/debugger-pause-on-blocked-event-handler.html

[Build Bot]

Created attachment 212872 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 212869 [details]
Fix WebCore

Attachment 212869 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/2660337

New failing tests:
http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url.html
http/tests/security/contentSecurityPolicy/script-src-none-inline-event.html
inspector/debugger/debugger-pause-on-blocked-script-url.html
http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy.html
http/tests/security/contentSecurityPolicy/javascript-url-blocked.html
inspector/debugger/debugger-pause-on-blocked-event-handler.html

[Build Bot]

Created attachment 212873 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Mark Rowe (bdash)]

Comment on attachment 212869 [details]
Fix WebCore

Looks like I did something wrong in the ContentSecurityPolicy parts of this patch. I'll revise it.

[Build Bot]

Comment on attachment 212869 [details]
Fix WebCore

Attachment 212869 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/2660356

New failing tests:
http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url.html
http/tests/security/contentSecurityPolicy/script-src-none-inline-event.html
inspector/debugger/debugger-pause-on-blocked-script-url.html
http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy.html
http/tests/security/contentSecurityPolicy/javascript-url-blocked.html
inspector/debugger/debugger-pause-on-blocked-event-handler.html

[Build Bot]

Created attachment 212874 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Mark Rowe (bdash)]

Created attachment 212875 [details]
Fix WebCore v2

[WebKit Commit Bot]

Attachment 212875 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/indexeddb/IDBIndex.cpp', u'Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp', u'Source/WebCore/Modules/webaudio/AudioContext.cpp', u'Source/WebCore/Modules/webaudio/ScriptProcessorNode.cpp', u'Source/WebCore/Modules/webdatabase/SQLResultSet.cpp', u'Source/WebCore/Modules/webdatabase/SQLTransactionBackend.cpp', u'Source/WebCore/Modules/websockets/WebSocketHandshake.cpp', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/css/CSSGrammar.y.in', u'Source/WebCore/html/track/TextTrackCue.cpp', u'Source/WebCore/loader/TextResourceDecoder.cpp', u'Source/WebCore/page/ContentSecurityPolicy.cpp', u'Source/WebCore/page/animation/CSSPropertyAnimation.cpp', u'Source/WebCore/platform/mac/DisplaySleepDisabler.cpp', u'Source/WebCore/platform/mac/WebCoreFullScreenWarningView.mm', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayerCompositor.cpp', u'Source/WebCore/svg/SVGAnimatedAngle.cpp', u'Source/WebCore/svg/SVGUseElement.cpp', u'Source/WebCore/xml/XPathStep.cpp']" exit_code: 1
Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 212865 [details]
Fix WTF

Clearing flags on attachment: 212865

Committed r156596: <http://trac.webkit.org/changeset/156596>

[WebKit Commit Bot]

Comment on attachment 212866 [details]
Fix JavaScriptCore

Clearing flags on attachment: 212866

Committed r156597: <http://trac.webkit.org/changeset/156597>

[WebKit Commit Bot]

Comment on attachment 212868 [details]
Fix WebKit2

Clearing flags on attachment: 212868

Committed r156598: <http://trac.webkit.org/changeset/156598>

[WebKit Commit Bot]

Comment on attachment 212867 [details]
Fix WebKit

Clearing flags on attachment: 212867

Committed r156599: <http://trac.webkit.org/changeset/156599>

[WebKit Commit Bot]

Comment on attachment 212875 [details]
Fix WebCore v2

Clearing flags on attachment: 212875

Committed r156600: <http://trac.webkit.org/changeset/156600>

[WebKit Commit Bot]

Comment on attachment 212864 [details]
Fix an .xcconfig issue that affects several projects

Clearing flags on attachment: 212864

Committed r156611: <http://trac.webkit.org/changeset/156611>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.