Summary: | Center misspelling dots across width of word | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||
Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, jonlee, thorton | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Myles C. Maxfield
2013-09-27 17:58:42 PDT
Created attachment 213037 [details]
Patch
Comment on attachment 213037 [details]
Patch
Code change looks fine. And the spelling markers all look better. But the grammar markers in the test results seems to have a different style, with wider lines rather than dots. What is going on there?
The grammar dots come from calling + NSImage imageNamed: with @"NSGrammarDot" (and if that fails, then with @"GrammarDot"). I'm searching now for where these images are coming from. Comment on attachment 213037 [details] Patch Attachment 213037 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/2802100 Created attachment 213065 [details]
Patch
Comment on attachment 213065 [details] Patch Clearing flags on attachment: 213065 Committed r156716: <http://trac.webkit.org/changeset/156716> All reviewed patches have been landed. Closing bug. |