Bug 122032

Summary:

ASSERT(!m_hasBadParent) in InlineBox::parent() should be ASSERT_WITH_SECURITY_IMPLICATION

Product:

WebKit

Reporter:

Drew Yao <ayao>

Component:

Layout and Rendering

Assignee:

Drew Yao <ayao>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, kondapallykalyan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Drew Yao 2013-09-27 14:26:02 PDT

Source/WebCore/rendering/InlineBox.h:

    InlineFlowBox* parent() const
    {
        ASSERT(!m_hasBadParent);
        return m_parent;
    }


ASSERT(!m_hasBadParent) in InlineBox::parent() should be ASSERT_WITH_SECURITY_IMPLICATION.  Its sole purpose is to catch use after free bugs.

Comment 1 Drew Yao 2013-09-27 14:39:19 PDT

Created attachment 212841 [details]
Patch

Comment 2 WebKit Commit Bot 2013-09-30 14:54:46 PDT

Comment on attachment 212841 [details]
Patch

Clearing flags on attachment: 212841

Committed r156682: <http://trac.webkit.org/changeset/156682>

Comment 3 WebKit Commit Bot 2013-09-30 14:54:48 PDT

All reviewed patches have been landed.  Closing bug.