Bug 122021

Summary:	REGRESSION(r156546): 18 media tests broken
Product:	WebKit	Reporter:	Jer Noble <jer.noble>
Component:	Media	Assignee:	Nobody <webkit-unassigned>
Status:	NEW ---
Severity:	Normal	CC:	ben_schwartz, darin, hector_i_lopez, peng.liu6, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	528+ (Nightly build)
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=208507
Bug Depends on:	120895
Bug Blocks:	110173, 122022, 122049, 122050

Description Jer Noble 2013-09-27 10:34:23 PDT

17 media tests broke after http://trac.webkit.org/r156546, the fix for bug #120895:

media/track/track-cue-mutable-text.html
media/track/track-cue-rendering-mode-changed.html
media/track/track-in-band-mode.html
media/video-controls-captions-trackmenu-localized.html
media/video-controls-captions-trackmenu-sorted.html
media/video-controls-captions-trackmenu.html
media/video-controls-fullscreen-volume.html
media/video-controls-no-scripting.html
media/video-controls-rendering.html
media/video-controls-toggling.html
media/video-controls-visible-exiting-fullscreen.html
media/video-display-toggle.html
media/video-empty-source.html
media/video-no-audio.html
media/video-rtl.html
media/video-volume-slider.html
media/volume-bar-empty-when-muted.html

Comment 1 Jer Noble 2013-09-27 10:36:21 PDT

<rdar://problem/15099302>

Comment 2 Alexey Proskuryakov 2013-09-27 14:13:25 PDT

media/track/track-cue-rendering-vertical.html is also broken by this change, filing flakily (but most of the time). Will add to TestExpectations.

Comment 3 Jer Noble 2014-09-10 17:40:23 PDT

Rebased and marked as passing a few tests in r173500 <https://trac.webkit.org/r173500>.

Comment 4 Alexey Proskuryakov 2015-02-27 16:01:31 PST

media/video-controls-visible-exiting-fullscreen.html got fixed via bug 141689.

Comment 5 Darin Adler 2019-12-20 09:51:07 PST

media/track/track-cue-rendering-mode-changed.html is passing on my Catalina machine, not timing out as the expectations file says.

Comment 6 Hector Lopez 2020-08-20 19:06:13 PDT

media/track/track-cue-rendering-mode-changed.html

Test is a flaky failure according to history on macOS wk1. First occurrence of failure is a r260834.

History:
https://results.webkit.org/?suite=layout-tests&test=media%2Ftrack%2Ftrack-cue-rendering-mode-changed.html&limit=50000&platform=mac&flavor=wk1

Diff:
--- /Volumes/Data/slave/catalina-release-tests-wk1/build/layout-test-results/media/track/track-cue-rendering-mode-changed-expected.txt
+++ /Volumes/Data/slave/catalina-release-tests-wk1/build/layout-test-results/media/track/track-cue-rendering-mode-changed-actual.txt
@@ -21,7 +21,7 @@
 Set the mode of the 'English' track to showing
 
 ** Both cues shold be visible. **
-EXPECTED (testCueDisplayBox.innerText == 'Arabic') OK
-EXPECTED (testCueDisplayBox.innerText == 'English') OK
+EXPECTED (testCueDisplayBox.innerText == 'Arabic'), OBSERVED 'English' FAIL
+EXPECTED (testCueDisplayBox.innerText == 'English'), OBSERVED 'Arabic' FAIL
 END OF TEST

Comment 7 Ben Schwartz 2023-09-11 10:16:57 PDT

Regression point canonical: https://commits.webkit.org/140045@main

Comment 8 Ben Schwartz 2023-09-11 14:00:04 PDT

This is still occurring on macOS Ventura (13.5, 22G74/arm64) ToT 10 years later.