Bug 121956

Summary: [Qt] Mock implementations of positioning and orientation not used
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: Tools / TestsAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, commit-queue, hausmann, kadam, ossy, zarvai
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Allan Sandfeld Jensen
Reported 2013-09-26 07:32:47 PDT
A regression on the bots was introduced by the patch for bug #121089. The problem is the state of production_build is not known at the time detectFeatures is run.
Attachments
Patch (3.58 KB, patch)
2013-09-26 07:34 PDT, Allan Sandfeld Jensen
no flags
Allan Sandfeld Jensen
Comment 1 2013-09-26 07:34:46 PDT
Csaba Osztrogonác
Comment 2 2013-09-27 04:09:17 PDT
Comment on attachment 212705 [details] Patch LGTM, r=me.
Zoltan Arvai
Comment 3 2013-09-27 04:12:14 PDT
(In reply to comment #2) > (From update of attachment 212705 [details]) > LGTM, r=me. Yes, the related test are not failing on local my system with this patch.
WebKit Commit Bot
Comment 4 2013-09-27 04:56:39 PDT
Comment on attachment 212705 [details] Patch Clearing flags on attachment: 212705 Committed r156534: <http://trac.webkit.org/changeset/156534>
WebKit Commit Bot
Comment 5 2013-09-27 04:56:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.