Bug 121956 - [Qt] Mock implementations of positioning and orientation not used
Summary: [Qt] Mock implementations of positioning and orientation not used
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-26 07:32 PDT by Allan Sandfeld Jensen
Modified: 2013-09-27 04:56 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.58 KB, patch)
2013-09-26 07:34 PDT, Allan Sandfeld Jensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2013-09-26 07:32:47 PDT 
A regression on the bots was introduced by the patch for bug #121089. The problem is the state of production_build is not known at the time detectFeatures is run.
Comment 1 Allan Sandfeld Jensen 2013-09-26 07:34:46 PDT 
Created attachment 212705 [details]
Patch
Comment 2 Csaba Osztrogonác 2013-09-27 04:09:17 PDT 
Comment on attachment 212705 [details]
Patch

LGTM, r=me.
Comment 3 Zoltan Arvai 2013-09-27 04:12:14 PDT 
(In reply to comment #2)
> (From update of attachment 212705 [details])
> LGTM, r=me.

Yes, the related test are not failing on local my system with this patch.
Comment 4 WebKit Commit Bot 2013-09-27 04:56:39 PDT 
Comment on attachment 212705 [details]
Patch

Clearing flags on attachment: 212705

Committed r156534: <http://trac.webkit.org/changeset/156534>
Comment 5 WebKit Commit Bot 2013-09-27 04:56:42 PDT 
All reviewed patches have been landed.  Closing bug.