Bug 121951 – XvfbDriver should set up Xvfb instances providing screens of 8-bit depth

• Component: New Bugs
• Status: RESOLVED FIXED

[Zan Dobersek]

XvfbDriver should set up Xvfb instances providing screens of 8-bit depth

[Zan Dobersek]

Created attachment 212698 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 212698 [details]
Patch

This is also what xvfb-run does by default. I guess you have checked all test still pass.

[Zan Dobersek]

Comment on attachment 212698 [details]
Patch

Clearing flags on attachment: 212698

Committed r156457: <http://trac.webkit.org/changeset/156457>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.

[Jessie Berlin]

This broke the webkitpy tests:

http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20WK1%20%28Tests%29/builds/10416/steps/webkitpy-test/logs/stdio

Running the tests ...
[883/1467] webkitpy.port.xvfbdriver_unittest.XvfbDriverTest.test_start_next_worker failed:
  Traceback (most recent call last):
    File "/Volumes/Data/slave/mountainlion-debug-tests-wk1/build/Tools/Scripts/webkitpy/port/xvfbdriver_unittest.py", line 111, in test_start_next_worker
      self.assertDriverStartSuccessful(driver, expected_logs=expected_logs, expected_display=":0", pixel_tests=True)
    File "/Volumes/Data/slave/mountainlion-debug-tests-wk1/build/Tools/Scripts/webkitpy/port/xvfbdriver_unittest.py", line 63, in assertDriverStartSuccessful
      OutputCapture().assert_outputs(self, driver.start, [pixel_tests, []], expected_logs=expected_logs)
    File "/Volumes/Data/slave/mountainlion-debug-tests-wk1/build/Tools/Scripts/webkitpy/common/system/outputcapture.py", line 105, in assert_outputs
      testassert(logs_string, expected_logs)
  AssertionError: "MOCK popen: ['Xvfb', ':0', '-screen', '0', '800x600x8', '-nolisten', 'tcp']\n" != "MOCK popen: ['Xvfb', ':0', '-screen', '0', '800x600x24', '-nolisten', 'tcp']\n" [truncated]...
  - MOCK popen: ['Xvfb', ':0', '-screen', '0', '800x600x8', '-nolisten', 'tcp']
  ?                                                     ^
  + MOCK popen: ['Xvfb', ':0', '-screen', '0', '800x600x24', '-nolisten', 'tcp']
  ?                                                     ^^
  
  
[891/1467] webkitpy.port.xvfbdriver_unittest.XvfbDriverTest.test_start_pixel_tests failed:
  Traceback (most recent call last):
    File "/Volumes/Data/slave/mountainlion-debug-tests-wk1/build/Tools/Scripts/webkitpy/port/xvfbdriver_unittest.py", line 76, in test_start_pixel_tests
      self.assertDriverStartSuccessful(driver, expected_logs=expected_logs, expected_display=":0", pixel_tests=True)
    File "/Volumes/Data/slave/mountainlion-debug-tests-wk1/build/Tools/Scripts/webkitpy/port/xvfbdriver_unittest.py", line 63, in assertDriverStartSuccessful
      OutputCapture().assert_outputs(self, driver.start, [pixel_tests, []], expected_logs=expected_logs)
    File "/Volumes/Data/slave/mountainlion-debug-tests-wk1/build/Tools/Scripts/webkitpy/common/system/outputcapture.py", line 105, in assert_outputs
      testassert(logs_string, expected_logs)
  AssertionError: "MOCK run_command: ['ps', '-eo', 'comm,command'], cwd=None\nMOCK popen: ['Xvfb', [truncated]... != "MOCK run_command: ['ps', '-eo', 'comm,command'], cwd=None\nMOCK popen: ['Xvfb', [truncated]...
    MOCK run_command: ['ps', '-eo', 'comm,command'], cwd=None
  - MOCK popen: ['Xvfb', ':0', '-screen', '0', '800x600x8', '-nolisten', 'tcp']
  ?                                                     ^
  + MOCK popen: ['Xvfb', ':0', '-screen', '0', '800x600x24', '-nolisten', 'tcp']
  ?                                                     ^^
  
  
[892/1467] webkitpy.port.xvfbdriver_unittest.XvfbDriverTest.test_start_no_pixel_tests failed:
  Traceback (most recent call last):
    File "/Volumes/Data/slave/mountainlion-debug-tests-wk1/build/Tools/Scripts/webkitpy/port/xvfbdriver_unittest.py", line 70, in test_start_no_pixel_tests
      self.assertDriverStartSuccessful(driver, expected_logs=expected_logs, expected_display=":0")
    File "/Volumes/Data/slave/mountainlion-debug-tests-wk1/build/Tools/Scripts/webkitpy/port/xvfbdriver_unittest.py", line 63, in assertDriverStartSuccessful
      OutputCapture().assert_outputs(self, driver.start, [pixel_tests, []], expected_logs=expected_logs)
    File "/Volumes/Data/slave/mountainlion-debug-tests-wk1/build/Tools/Scripts/webkitpy/common/system/outputcapture.py", line 105, in assert_outputs
      testassert(logs_string, expected_logs)
  AssertionError: "MOCK run_command: ['ps', '-eo', 'comm,command'], cwd=None\nMOCK popen: ['Xvfb', [truncated]... != "MOCK run_command: ['ps', '-eo', 'comm,command'], cwd=None\nMOCK popen: ['Xvfb', [truncated]...
    MOCK run_command: ['ps', '-eo', 'comm,command'], cwd=None
  - MOCK popen: ['Xvfb', ':0', '-screen', '0', '800x600x8', '-nolisten', 'tcp']
  ?                                                     ^
  + MOCK popen: ['Xvfb', ':0', '-screen', '0', '800x600x24', '-nolisten', 'tcp']
  ?                                                     ^^
  
  
[1113/1467] webkitpy.port.xvfbdriver_unittest.XvfbDriverTest.test_start_arbitrary_worker_number failed:
  Traceback (most recent call last):
    File "/Volumes/Data/slave/mountainlion-debug-tests-wk1/build/Tools/Scripts/webkitpy/port/xvfbdriver_unittest.py", line 82, in test_start_arbitrary_worker_number
      self.assertDriverStartSuccessful(driver, expected_logs=expected_logs, expected_display=":0", pixel_tests=True)
    File "/Volumes/Data/slave/mountainlion-debug-tests-wk1/build/Tools/Scripts/webkitpy/port/xvfbdriver_unittest.py", line 63, in assertDriverStartSuccessful
      OutputCapture().assert_outputs(self, driver.start, [pixel_tests, []], expected_logs=expected_logs)
    File "/Volumes/Data/slave/mountainlion-debug-tests-wk1/build/Tools/Scripts/webkitpy/common/system/outputcapture.py", line 105, in assert_outputs
      testassert(logs_string, expected_logs)
  AssertionError: "MOCK run_command: ['ps', '-eo', 'comm,command'], cwd=None\nMOCK popen: ['Xvfb', [truncated]... != "MOCK run_command: ['ps', '-eo', 'comm,command'], cwd=None\nMOCK popen: ['Xvfb', [truncated]...
    MOCK run_command: ['ps', '-eo', 'comm,command'], cwd=None
  - MOCK popen: ['Xvfb', ':0', '-screen', '0', '800x600x8', '-nolisten', 'tcp']
  ?                                                     ^
  + MOCK popen: ['Xvfb', ':0', '-screen', '0', '800x600x24', '-nolisten', 'tcp']
  ?                                                     ^^
  
  
Ran 1467 tests in 6.742s
FAILED (failures=4, errors=0)
program finished with exit code 1
elapsedTime=9.172221

[WebKit Commit Bot]

Re-opened since this is blocked by bug 121960

[Zan Dobersek]

Created attachment 212722 [details]
Patch

[Zan Dobersek]

Comment on attachment 212722 [details]
Patch

Clearing flags on attachment: 212722

Committed r156475: <http://trac.webkit.org/changeset/156475>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.

[Alberto Garcia]

This also broke fast/dom/Window/window-screen-properties.html

[Ryuan Choi]

(In reply to comment #10)
> This also broke fast/dom/Window/window-screen-properties.html

And FYI, EFL port got too many failing cases after this patch.

[Gyuyoung Kim]

(In reply to comment #11)
> (In reply to comment #10)
> > This also broke fast/dom/Window/window-screen-properties.html
> 
> And FYI, EFL port got too many failing cases after this patch.

Hmm, is there any method EFL port doesn't adjust this patch for now ? EFL bots has happened lots of regression after this patch.

[Zan Dobersek]

(In reply to comment #12)
> (In reply to comment #11)
> > (In reply to comment #10)
> > > This also broke fast/dom/Window/window-screen-properties.html
> > 
> > And FYI, EFL port got too many failing cases after this patch.
> 
> Hmm, is there any method EFL port doesn't adjust this patch for now ? EFL bots has happened lots of regression after this patch.

Handled in bug #122089.

(In reply to comment #10)
> This also broke fast/dom/Window/window-screen-properties.html

Unfortunately the test will not be fixable until we require the 8-bit depth hack on the GTK 64-bit release builder.

[Gustavo Noronha (kov)]

Hmm, so we do get GL software rendering on the 64 bits release bot?