Bug 121939

Summary: [MediaStream API] update MediaStream object to match spec
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dino, esprehn+autocc, glenn, hta, jer.noble, kondapallykalyan, thiago.lacerda, tommyw
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 124288    
Attachments:
Description Flags
Patch
none
Patch for committing. none

Eric Carlson
Reported 2013-09-25 21:59:28 PDT
- missing: MediaStream clone (); - not in spec: void stop(); // moved to MediaStreamTrack ? <rdar://problem/15022373>
Attachments
Patch (8.85 KB, patch)
2013-10-10 13:31 PDT, Thiago de Barros Lacerda 		no flags
DetailsFormatted DiffDiff
Patch for committing. (14.71 KB, patch)
2013-10-10 16:22 PDT, Thiago de Barros Lacerda 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Thiago de Barros Lacerda
Comment 1 2013-10-10 13:31:53 PDT
Created attachment 213922 [details] Patch
Jer Noble
Comment 2 2013-10-10 13:46:09 PDT
Was there no existing test which exercised MediaStream.stop()?
Thiago de Barros Lacerda
Comment 3 2013-10-10 13:51:05 PDT
(In reply to comment #2) > Was there no existing test which exercised MediaStream.stop()? I forgot to check that. There is some, I will update them
Jer Noble
Comment 4 2013-10-10 14:18:48 PDT
Comment on attachment 213922 [details] Patch In that case, r=me.
Jer Noble
Comment 5 2013-10-10 14:19:50 PDT
(i.e., Just post another patch with the test changes and name it "Patch for committing.")
Thiago de Barros Lacerda
Comment 6 2013-10-10 16:22:29 PDT
Created attachment 213942 [details] Patch for committing.
WebKit Commit Bot
Comment 7 2013-10-10 16:54:37 PDT
Comment on attachment 213942 [details] Patch for committing. Clearing flags on attachment: 213942 Committed r157273: <http://trac.webkit.org/changeset/157273>
WebKit Commit Bot
Comment 8 2013-10-10 16:54:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.