Bug 121939

Summary: [MediaStream API] update MediaStream object to match spec
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dino, esprehn+autocc, glenn, hta, jer.noble, kondapallykalyan, thiago.lacerda, tommyw
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 124288    
Attachments:
Description Flags
Patch
none
Patch for committing. none

Description Eric Carlson 2013-09-25 21:59:28 PDT 
- missing:
    MediaStream  clone ();

- not in spec:
    void stop();	// moved to MediaStreamTrack ?

<rdar://problem/15022373>
Comment 1 Thiago de Barros Lacerda 2013-10-10 13:31:53 PDT 
Created attachment 213922 [details]
Patch
Comment 2 Jer Noble 2013-10-10 13:46:09 PDT 
Was there no existing test which exercised MediaStream.stop()?
Comment 3 Thiago de Barros Lacerda 2013-10-10 13:51:05 PDT 
(In reply to comment #2)
> Was there no existing test which exercised MediaStream.stop()?
I forgot to check that. There is some, I will update them
Comment 4 Jer Noble 2013-10-10 14:18:48 PDT 
Comment on attachment 213922 [details]
Patch

In that case, r=me.
Comment 5 Jer Noble 2013-10-10 14:19:50 PDT 
(i.e., Just post another patch with the test changes and name it "Patch for committing.")
Comment 6 Thiago de Barros Lacerda 2013-10-10 16:22:29 PDT 
Created attachment 213942 [details]
Patch for committing.
Comment 7 WebKit Commit Bot 2013-10-10 16:54:37 PDT 
Comment on attachment 213942 [details]
Patch for committing.

Clearing flags on attachment: 213942

Committed r157273: <http://trac.webkit.org/changeset/157273>
Comment 8 WebKit Commit Bot 2013-10-10 16:54:39 PDT 
All reviewed patches have been landed.  Closing bug.