Summary: | Pass a JSC::VM& to JS bindings object creation functions, rather than a JSC::ExecState* | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cdumez, commit-queue, webkit-ews | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Sam Weinig
2013-09-25 18:43:00 PDT
Created attachment 212650 [details]
Patch
This will probably take a few tries, so first let's let the bots at it. Attachment 212650 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/bindings/js/JSDOMBinding.h', u'Source/WebCore/bindings/js/JSDOMGlobalObject.h', u'Source/WebCore/bindings/js/JSDOMWindowCustom.cpp', u'Source/WebCore/bindings/js/JSDocumentCustom.cpp', u'Source/WebCore/bindings/js/JSImageConstructor.cpp', u'Source/WebCore/bindings/js/JSImageConstructor.h', u'Source/WebCore/bindings/js/ScriptWrappable.h', u'Source/WebCore/bindings/js/ScriptWrappableInlines.h', u'Source/WebCore/bindings/scripts/CodeGeneratorJS.pm', u'Source/WebCore/bridge/c/CRuntimeObject.cpp', u'Source/WebCore/bridge/c/CRuntimeObject.h', u'Source/WebCore/bridge/c/c_instance.cpp', u'Source/WebCore/bridge/jsc/BridgeJSC.cpp', u'Source/WebCore/bridge/objc/ObjCRuntimeObject.h', u'Source/WebCore/bridge/objc/ObjCRuntimeObject.mm', u'Source/WebCore/bridge/objc/objc_instance.mm', u'Source/WebCore/bridge/objc/objc_runtime.h', u'Source/WebCore/bridge/runtime_array.h', u'Source/WebCore/bridge/runtime_method.h', u'Source/WebCore/bridge/runtime_object.cpp', u'Source/WebCore/bridge/runtime_object.h', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/Plugins/Hosted/ProxyInstance.mm', u'Source/WebKit/mac/Plugins/Hosted/ProxyRuntimeObject.h', u'Source/WebKit/mac/Plugins/Hosted/ProxyRuntimeObject.mm']" exit_code: 1
Source/WebCore/bridge/c/CRuntimeObject.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 27 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 212650 [details] Patch Attachment 212650 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/2230095 Comment on attachment 212650 [details] Patch Attachment 212650 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/2202081 Created attachment 212653 [details]
Patch
Attachment 212653 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/bindings/js/JSDOMBinding.h', u'Source/WebCore/bindings/js/JSDOMGlobalObject.h', u'Source/WebCore/bindings/js/JSDOMWindowCustom.cpp', u'Source/WebCore/bindings/js/JSDocumentCustom.cpp', u'Source/WebCore/bindings/js/JSImageConstructor.cpp', u'Source/WebCore/bindings/js/JSImageConstructor.h', u'Source/WebCore/bindings/js/ScriptWrappable.h', u'Source/WebCore/bindings/js/ScriptWrappableInlines.h', u'Source/WebCore/bindings/scripts/CodeGeneratorJS.pm', u'Source/WebCore/bridge/c/CRuntimeObject.cpp', u'Source/WebCore/bridge/c/CRuntimeObject.h', u'Source/WebCore/bridge/c/c_instance.cpp', u'Source/WebCore/bridge/jsc/BridgeJSC.cpp', u'Source/WebCore/bridge/objc/ObjCRuntimeObject.h', u'Source/WebCore/bridge/objc/ObjCRuntimeObject.mm', u'Source/WebCore/bridge/objc/objc_instance.mm', u'Source/WebCore/bridge/objc/objc_runtime.h', u'Source/WebCore/bridge/qt/qt_instance.cpp', u'Source/WebCore/bridge/runtime_array.h', u'Source/WebCore/bridge/runtime_method.h', u'Source/WebCore/bridge/runtime_object.cpp', u'Source/WebCore/bridge/runtime_object.h', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/Plugins/Hosted/ProxyInstance.mm', u'Source/WebKit/mac/Plugins/Hosted/ProxyRuntimeObject.h', u'Source/WebKit/mac/Plugins/Hosted/ProxyRuntimeObject.mm']" exit_code: 1
Source/WebCore/bridge/c/CRuntimeObject.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 28 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 212653 [details] Patch Attachment 212653 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/2165116 Comment on attachment 212653 [details] Patch Attachment 212653 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/2209115 Created attachment 212655 [details]
Patch
Attachment 212655 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/bindings/js/JSDOMBinding.h', u'Source/WebCore/bindings/js/JSDOMGlobalObject.h', u'Source/WebCore/bindings/js/JSDOMWindowCustom.cpp', u'Source/WebCore/bindings/js/JSDocumentCustom.cpp', u'Source/WebCore/bindings/js/JSImageConstructor.cpp', u'Source/WebCore/bindings/js/JSImageConstructor.h', u'Source/WebCore/bindings/js/ScriptWrappable.h', u'Source/WebCore/bindings/js/ScriptWrappableInlines.h', u'Source/WebCore/bindings/scripts/CodeGeneratorJS.pm', u'Source/WebCore/bridge/c/CRuntimeObject.cpp', u'Source/WebCore/bridge/c/CRuntimeObject.h', u'Source/WebCore/bridge/c/c_instance.cpp', u'Source/WebCore/bridge/jsc/BridgeJSC.cpp', u'Source/WebCore/bridge/objc/ObjCRuntimeObject.h', u'Source/WebCore/bridge/objc/ObjCRuntimeObject.mm', u'Source/WebCore/bridge/objc/objc_instance.mm', u'Source/WebCore/bridge/objc/objc_runtime.h', u'Source/WebCore/bridge/qt/qt_instance.cpp', u'Source/WebCore/bridge/runtime_array.h', u'Source/WebCore/bridge/runtime_method.h', u'Source/WebCore/bridge/runtime_object.cpp', u'Source/WebCore/bridge/runtime_object.h', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/Plugins/Hosted/ProxyInstance.mm', u'Source/WebKit/mac/Plugins/Hosted/ProxyRuntimeObject.h', u'Source/WebKit/mac/Plugins/Hosted/ProxyRuntimeObject.mm']" exit_code: 1
Source/WebCore/bridge/c/CRuntimeObject.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 28 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 212655 [details]
Patch
r=me
Committed r156485: <http://trac.webkit.org/changeset/156485> |