Bug 121934

Summary:

Pass a JSC::VM& to JS bindings object creation functions, rather than a JSC::ExecState*

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, webkit-ews

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	ggaren: review+

Sam Weinig

Reported 2013-09-25 18:43:00 PDT

Pass a JSC::VM& to JS bindings object creation functions, rather than a JSC::ExecState*

Attachments
Patch (42.35 KB, patch) 2013-09-25 18:47 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (44.57 KB, patch) 2013-09-25 19:20 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (44.58 KB, patch) 2013-09-25 19:43 PDT, Sam Weinig	ggaren: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2013-09-25 18:47:10 PDT

Created attachment 212650 [details] Patch

Sam Weinig

Comment 2 2013-09-25 18:47:33 PDT

This will probably take a few tries, so first let's let the bots at it.

WebKit Commit Bot

Comment 3 2013-09-25 18:49:35 PDT

Attachment 212650 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/bindings/js/JSDOMBinding.h', u'Source/WebCore/bindings/js/JSDOMGlobalObject.h', u'Source/WebCore/bindings/js/JSDOMWindowCustom.cpp', u'Source/WebCore/bindings/js/JSDocumentCustom.cpp', u'Source/WebCore/bindings/js/JSImageConstructor.cpp', u'Source/WebCore/bindings/js/JSImageConstructor.h', u'Source/WebCore/bindings/js/ScriptWrappable.h', u'Source/WebCore/bindings/js/ScriptWrappableInlines.h', u'Source/WebCore/bindings/scripts/CodeGeneratorJS.pm', u'Source/WebCore/bridge/c/CRuntimeObject.cpp', u'Source/WebCore/bridge/c/CRuntimeObject.h', u'Source/WebCore/bridge/c/c_instance.cpp', u'Source/WebCore/bridge/jsc/BridgeJSC.cpp', u'Source/WebCore/bridge/objc/ObjCRuntimeObject.h', u'Source/WebCore/bridge/objc/ObjCRuntimeObject.mm', u'Source/WebCore/bridge/objc/objc_instance.mm', u'Source/WebCore/bridge/objc/objc_runtime.h', u'Source/WebCore/bridge/runtime_array.h', u'Source/WebCore/bridge/runtime_method.h', u'Source/WebCore/bridge/runtime_object.cpp', u'Source/WebCore/bridge/runtime_object.h', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/Plugins/Hosted/ProxyInstance.mm', u'Source/WebKit/mac/Plugins/Hosted/ProxyRuntimeObject.h', u'Source/WebKit/mac/Plugins/Hosted/ProxyRuntimeObject.mm']" exit_code: 1 Source/WebCore/bridge/c/CRuntimeObject.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 4 2013-09-25 18:57:24 PDT

Comment on attachment 212650 [details] Patch Attachment 212650 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/2230095

Early Warning System Bot

Comment 5 2013-09-25 18:58:41 PDT

Comment on attachment 212650 [details] Patch Attachment 212650 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/2202081

Sam Weinig

Comment 6 2013-09-25 19:20:19 PDT

Created attachment 212653 [details] Patch

WebKit Commit Bot

Comment 7 2013-09-25 19:21:52 PDT

Attachment 212653 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/bindings/js/JSDOMBinding.h', u'Source/WebCore/bindings/js/JSDOMGlobalObject.h', u'Source/WebCore/bindings/js/JSDOMWindowCustom.cpp', u'Source/WebCore/bindings/js/JSDocumentCustom.cpp', u'Source/WebCore/bindings/js/JSImageConstructor.cpp', u'Source/WebCore/bindings/js/JSImageConstructor.h', u'Source/WebCore/bindings/js/ScriptWrappable.h', u'Source/WebCore/bindings/js/ScriptWrappableInlines.h', u'Source/WebCore/bindings/scripts/CodeGeneratorJS.pm', u'Source/WebCore/bridge/c/CRuntimeObject.cpp', u'Source/WebCore/bridge/c/CRuntimeObject.h', u'Source/WebCore/bridge/c/c_instance.cpp', u'Source/WebCore/bridge/jsc/BridgeJSC.cpp', u'Source/WebCore/bridge/objc/ObjCRuntimeObject.h', u'Source/WebCore/bridge/objc/ObjCRuntimeObject.mm', u'Source/WebCore/bridge/objc/objc_instance.mm', u'Source/WebCore/bridge/objc/objc_runtime.h', u'Source/WebCore/bridge/qt/qt_instance.cpp', u'Source/WebCore/bridge/runtime_array.h', u'Source/WebCore/bridge/runtime_method.h', u'Source/WebCore/bridge/runtime_object.cpp', u'Source/WebCore/bridge/runtime_object.h', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/Plugins/Hosted/ProxyInstance.mm', u'Source/WebKit/mac/Plugins/Hosted/ProxyRuntimeObject.h', u'Source/WebKit/mac/Plugins/Hosted/ProxyRuntimeObject.mm']" exit_code: 1 Source/WebCore/bridge/c/CRuntimeObject.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 8 2013-09-25 19:32:18 PDT

Comment on attachment 212653 [details] Patch Attachment 212653 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/2165116

Early Warning System Bot

Comment 9 2013-09-25 19:33:46 PDT

Comment on attachment 212653 [details] Patch Attachment 212653 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/2209115

Sam Weinig

Comment 10 2013-09-25 19:43:58 PDT

Created attachment 212655 [details] Patch

WebKit Commit Bot

Comment 11 2013-09-25 19:45:10 PDT

Attachment 212655 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/bindings/js/JSDOMBinding.h', u'Source/WebCore/bindings/js/JSDOMGlobalObject.h', u'Source/WebCore/bindings/js/JSDOMWindowCustom.cpp', u'Source/WebCore/bindings/js/JSDocumentCustom.cpp', u'Source/WebCore/bindings/js/JSImageConstructor.cpp', u'Source/WebCore/bindings/js/JSImageConstructor.h', u'Source/WebCore/bindings/js/ScriptWrappable.h', u'Source/WebCore/bindings/js/ScriptWrappableInlines.h', u'Source/WebCore/bindings/scripts/CodeGeneratorJS.pm', u'Source/WebCore/bridge/c/CRuntimeObject.cpp', u'Source/WebCore/bridge/c/CRuntimeObject.h', u'Source/WebCore/bridge/c/c_instance.cpp', u'Source/WebCore/bridge/jsc/BridgeJSC.cpp', u'Source/WebCore/bridge/objc/ObjCRuntimeObject.h', u'Source/WebCore/bridge/objc/ObjCRuntimeObject.mm', u'Source/WebCore/bridge/objc/objc_instance.mm', u'Source/WebCore/bridge/objc/objc_runtime.h', u'Source/WebCore/bridge/qt/qt_instance.cpp', u'Source/WebCore/bridge/runtime_array.h', u'Source/WebCore/bridge/runtime_method.h', u'Source/WebCore/bridge/runtime_object.cpp', u'Source/WebCore/bridge/runtime_object.h', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/Plugins/Hosted/ProxyInstance.mm', u'Source/WebKit/mac/Plugins/Hosted/ProxyRuntimeObject.h', u'Source/WebKit/mac/Plugins/Hosted/ProxyRuntimeObject.mm']" exit_code: 1 Source/WebCore/bridge/c/CRuntimeObject.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.

Geoffrey Garen

Comment 12 2013-09-25 20:13:17 PDT

Comment on attachment 212655 [details] Patch r=me

Sam Weinig

Comment 13 2013-09-26 12:07:45 PDT

Committed r156485: <http://trac.webkit.org/changeset/156485>

Note You need to log in before you can comment on or make changes to this bug.