Summary: | Layout assertion failure in WebCore::RenderView::paint | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
Component: | Layout and Rendering | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, ap, commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser, thorton, zalan | ||||
Priority: | P2 | Keywords: | InRadar, LayoutTestFailure | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Ryosuke Niwa
2013-09-25 14:04:44 PDT
This seems to have recently started to happen on platform/mac-wk2/tiled-drawing tests a lot. The following functions don't seem to update the layout. WebCore::RenderLayer::paintLayerContents RenderLayerBacking::paintContents WebCore::GraphicsLayer::paintGraphicsLayerContents WebCore::GraphicsLayerCA::platformCALayerPaintContents drawLayerContents TileController::drawLayer -[WebTileLayer drawInContext:] Who is responsible for updating the layout here? (In reply to comment #2) > The following functions don't seem to update the layout. > > WebCore::RenderLayer::paintLayerContents > RenderLayerBacking::paintContents > WebCore::GraphicsLayer::paintGraphicsLayerContents > WebCore::GraphicsLayerCA::platformCALayerPaintContents > drawLayerContents > TileController::drawLayer > -[WebTileLayer drawInContext:] > > Who is responsible for updating the layout here? LayerFlushScheduler’s run loop observer is always responsible for updating layout before CA painting callbacks occur. https://bugs.webkit.org/show_bug.cgi?id=121859 could potentially mean that this happens a lot more often, so I may end up blocked on this/having to look at this soon. <rdar://problem/15153588> Still happening a lot. Created attachment 213836 [details]
Patch
https://trac.webkit.org/r157198 This may not fix the non-TestWebKitAPI assertions. We'll see. With a night worth of testing, it seems that maybe it did fix assertions on platform/mac-wk2/tiled-drawing tests! Amazing! |