Bug 121923

Summary: AssembleBuildLogs should be enabled on WinCairo port
Product: WebKit Reporter: Alex Christensen <alex.christensen>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
bfulgham: review-
patch none

Alex Christensen
Reported 2013-09-25 13:26:59 PDT
Daily builds would be nicer if there were a log with them, or a log to show what someone needs to fix. There's also a bit of maintenance I've done. I'm not sure why it outputs to BuildOutput.htm when it's just an unformatted text file, but I'm not going to change that right now.
Attachments
Patch (40.10 KB, patch)
2013-09-25 13:45 PDT, Alex Christensen 		bfulgham: review-
DetailsFormatted DiffDiff
patch (36.92 KB, patch)
2013-09-25 14:04 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2013-09-25 13:45:45 PDT
Created attachment 212621 [details] Patch
Alex Christensen
Comment 2 2013-09-25 13:47:41 PDT
Comment on attachment 212621 [details] Patch Dang layout tests!
Brent Fulgham
Comment 3 2013-09-25 13:51:39 PDT
Comment on attachment 212621 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212621&action=review I think the patch has some unintentional LayoutTest changes in it. Can you get rid of them? > LayoutTests/css2.1/20110323/support/at-import-001.css:-3 > - color: red; What's all this stuff? > LayoutTests/css2.1/20110323/support/at-import-002.css:-3 > - color: green; Ditto...
Alex Christensen
Comment 4 2013-09-25 14:04:05 PDT
Created attachment 212623 [details] patch
Brent Fulgham
Comment 5 2013-09-25 17:04:40 PDT
Comment on attachment 212623 [details] patch r=me
WebKit Commit Bot
Comment 6 2013-09-25 17:51:51 PDT
Comment on attachment 212623 [details] patch Clearing flags on attachment: 212623 Committed r156437: <http://trac.webkit.org/changeset/156437>
WebKit Commit Bot
Comment 7 2013-09-25 17:51:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.