Bug 121923 - AssembleBuildLogs should be enabled on WinCairo port
Summary: AssembleBuildLogs should be enabled on WinCairo port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-25 13:26 PDT by Alex Christensen
Modified: 2013-09-25 17:51 PDT (History)
2 users (show)

See Also:

Attachments
Patch (40.10 KB, patch)
2013-09-25 13:45 PDT, Alex Christensen 		bfulgham: review-
Details | Formatted Diff | Diff
patch (36.92 KB, patch)
2013-09-25 14:04 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-09-25 13:26:59 PDT 
Daily builds would be nicer if there were a log with them, or a log to show what someone needs to fix.  There's also a bit of maintenance I've done.  I'm not sure why it outputs to BuildOutput.htm when it's just an unformatted text file, but I'm not going to change that right now.
Comment 1 Alex Christensen 2013-09-25 13:45:45 PDT 
Created attachment 212621 [details]
Patch
Comment 2 Alex Christensen 2013-09-25 13:47:41 PDT 
Comment on attachment 212621 [details]
Patch

Dang layout tests!
Comment 3 Brent Fulgham 2013-09-25 13:51:39 PDT 
Comment on attachment 212621 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212621&action=review

I think the patch has some unintentional LayoutTest changes in it.  Can you get rid of them?

> LayoutTests/css2.1/20110323/support/at-import-001.css:-3
> -    color: red;

What's all this stuff?

> LayoutTests/css2.1/20110323/support/at-import-002.css:-3
> -    color: green;

Ditto...
Comment 4 Alex Christensen 2013-09-25 14:04:05 PDT 
Created attachment 212623 [details]
patch
Comment 5 Brent Fulgham 2013-09-25 17:04:40 PDT 
Comment on attachment 212623 [details]
patch

r=me
Comment 6 WebKit Commit Bot 2013-09-25 17:51:51 PDT 
Comment on attachment 212623 [details]
patch

Clearing flags on attachment: 212623

Committed r156437: <http://trac.webkit.org/changeset/156437>
Comment 7 WebKit Commit Bot 2013-09-25 17:51:53 PDT 
All reviewed patches have been landed.  Closing bug.