Bug 121920

Summary: op_to_this shouldn't use value profiling
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 121074    
Attachments:
Description Flags
Patch none

Mark Hahnenberg
Reported 2013-09-25 13:06:34 PDT
Currently it's the only opcode that uses m_singletonValue, which is unnecessary. Our current plan is to remove m_singletonValue so that GenGC can have a simpler story for handling CodeBlocks/FunctionExecutables during nursery collections.
Attachments
Patch (22.84 KB, patch)
2013-09-25 14:10 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2013-09-25 14:10:36 PDT
Created attachment 212624 [details] Patch
Geoffrey Garen
Comment 2 2013-09-25 17:55:01 PDT
Comment on attachment 212624 [details] Patch r=me
WebKit Commit Bot
Comment 3 2013-09-26 10:15:37 PDT
Comment on attachment 212624 [details] Patch Clearing flags on attachment: 212624 Committed r156468: <http://trac.webkit.org/changeset/156468>
WebKit Commit Bot
Comment 4 2013-09-26 10:15:39 PDT
All reviewed patches have been landed. Closing bug.
Filip Pizlo
Comment 5 2013-10-01 20:14:06 PDT
This caused a 5-9% regression on V8Spider/deltablue.
Mark Hahnenberg
Comment 6 2013-10-02 09:26:25 PDT
(In reply to comment #5) > This caused a 5-9% regression on V8Spider/deltablue. According to whom? I ran benchmarks before landing.
Filip Pizlo
Comment 7 2013-10-02 11:27:16 PDT
(In reply to comment #6) > (In reply to comment #5) > > This caused a 5-9% regression on V8Spider/deltablue. > > According to whom? I ran benchmarks before landing. According to my Mac Pro.
Note You need to log in before you can comment on or make changes to this bug.