Bug 121919

Summary: JS wrappers should have strongly typed impl() functions.
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore JavaScriptAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dino, eric.carlson, glenn, jer.noble, kling, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Andreas Kling
Reported 2013-09-25 12:03:14 PDT
We should generate strongly-typed JSFoo::impl() for every wrapper class, not just those marked with JSGenerateToNativeObject. This'll reduce the need for magical casting all over WebCore.
Attachments
Patch (55.12 KB, patch)
2013-09-25 12:06 PDT, Andreas Kling 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-09-25 12:06:46 PDT
Created attachment 212613 [details] Patch
Geoffrey Garen
Comment 2 2013-09-25 12:23:29 PDT
Comment on attachment 212613 [details] Patch Please update run-bindings-tests results before landing.
Antonio Gomes
Comment 3 2013-09-25 12:32:22 PDT
Comment on attachment 212613 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212613&action=review > Source/WebCore/ChangeLog:9 > + not just those marked with JSGenerateToNativeObject. is JSGenerateToNativeObject support still needed by now?
Andreas Kling
Comment 4 2013-09-25 12:33:58 PDT
(In reply to comment #3) > (From update of attachment 212613 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=212613&action=review > > > Source/WebCore/ChangeLog:9 > > + not just those marked with JSGenerateToNativeObject. > > is JSGenerateToNativeObject support still needed by now? Yes, it's still needed for objects that want an autogenerated toWebCoreFoo() function.
Andreas Kling
Comment 5 2013-09-25 13:00:24 PDT
Committed r156419: <http://trac.webkit.org/changeset/156419>
Note You need to log in before you can comment on or make changes to this bug.