Summary: | Remove EventPathWalker. | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||||||||
Component: | UI Events | Assignee: | Andreas Kling <kling> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, esprehn+autocc, gyuyoung.kim, kangil.han, koivisto, rakuco, rniwa | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Andreas Kling
2013-09-24 19:19:01 PDT
Created attachment 212531 [details]
Patch for bots
Attachment 212531 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/dom/EventDispatcher.cpp', u'Source/WebCore/dom/EventPathWalker.cpp', u'Source/WebCore/dom/EventPathWalker.h', u'Source/WebCore/dom/EventRetargeter.cpp', u'Source/WebCore/html/HTMLLIElement.cpp', u'Source/WebCore/page/EventHandler.cpp']" exit_code: 1
Source/WebCore/dom/EventPathWalker.cpp:1: Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
Source/WebCore/dom/EventPathWalker.h:1: Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
Total errors found: 2 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 212531 [details] Patch for bots Attachment 212531 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/2233008 New failing tests: fast/css-generated-content/pseudo-transition-event.html Created attachment 212533 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 212534 [details]
Patch for bots
Fix pseudo element events.
Attachment 212534 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/dom/EventDispatcher.cpp', u'Source/WebCore/dom/EventPathWalker.cpp', u'Source/WebCore/dom/EventPathWalker.h', u'Source/WebCore/dom/EventRetargeter.cpp', u'Source/WebCore/html/HTMLLIElement.cpp', u'Source/WebCore/page/EventHandler.cpp']" exit_code: 1
Source/WebCore/dom/EventPathWalker.cpp:1: Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
Source/WebCore/dom/EventPathWalker.h:1: Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
Total errors found: 2 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 212534 [details] Patch for bots View in context: https://bugs.webkit.org/attachment.cgi?id=212534&action=review > Source/WebCore/dom/EventRetargeter.cpp:77 > +static Node* nodeOrHostIfPseudoPseudoElement(Node* node) Needs more Pseudo. Created attachment 212561 [details]
Patch
Created attachment 212562 [details]
Patch
With build systems.
Comment on attachment 212562 [details] Patch Clearing flags on attachment: 212562 Committed r156390: <http://trac.webkit.org/changeset/156390> All reviewed patches have been landed. Closing bug. |