Bug 121885

Summary:

[Windows] Overpanning occurs even when what is being panned isn't the main document

Product:

WebKit

Reporter:

Roger Fong <roger_fong>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, bfulgham, commit-queue, esprehn+autocc, glenn, jonlee, kondapallykalyan, roger_fong, simon.fraser

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 7

Attachments:

Description	Flags
patch	bfulgham: review+

Roger Fong

Reported 2013-09-24 17:38:14 PDT

When calling scrollbyrecursively we current keep track of the scrolled scrollview. However this does not take overflow scrolls into account. Hence what we see is that when we are panning an overflow scroll but the main document's scroll position is at either the beginning or end, overpanning occurs. We should instead keep track of the ScrollableArea since that encompasses both overflow scrolls and scroll views. <rdar://problem/15072332>

Attachments
patch (6.72 KB, patch) 2013-09-24 17:47 PDT, Roger Fong	bfulgham: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Roger Fong

Comment 1 2013-09-24 17:47:25 PDT

Created attachment 212527 [details] patch

Roger Fong

Comment 2 2013-09-25 11:34:31 PDT

Note that as of right now, only the Windows port uses the third argument in this method, and hence is the only one affected by this change.

Brent Fulgham

Comment 3 2013-09-25 11:36:51 PDT

Comment on attachment 212527 [details] patch r=me

Roger Fong

Comment 4 2013-09-25 12:05:04 PDT

Committed: http://trac.webkit.org/changeset/156416

Note You need to log in before you can comment on or make changes to this bug.