Bug 121882

Summary: Clean up some uses of first/lastChildSlow
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch kling: review+

Antti Koivisto
Reported 2013-09-24 17:14:28 PDT
tighten typing
Attachments
patch (22.33 KB, patch)
2013-09-24 17:20 PDT, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2013-09-24 17:20:47 PDT
Created attachment 212525 [details] patch
Andreas Kling
Comment 2 2013-09-24 17:31:28 PDT
Comment on attachment 212525 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=212525&action=review r=me > Source/WebCore/dom/Position.cpp:857 > + for (RenderObject *o = renderer.firstChild(); o && o != stop; o = o->nextInPreOrder()) * placement > Source/WebCore/rendering/RenderBlock.cpp:1074 > + if (anonymousBlock->continuation() || anonymousBlock->beingDestroyed()) > return false; We should postpone the continuation() check if possible, since it does a hash lookup. > Source/WebCore/rendering/RenderBlock.cpp:5956 > - RenderObject* firstLetterBlock = findFirstLetterBlock(this); > + RenderElement* firstLetterBlock = findFirstLetterBlock(this); I think we can make findFirstLetterBlock() return RenderBlock*.
Antti Koivisto
Comment 3 2013-09-24 18:00:32 PDT
https://trac.webkit.org/r156377
Note You need to log in before you can comment on or make changes to this bug.