Bug 121840

Summary: Cache continuation() in a local to avoid repeat hash lookups.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, eflews.bot, esprehn+autocc, glenn, gtk-ews, gyuyoung.kim, kondapallykalyan, philn, rniwa, webkit-ews, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ggaren: review+, webkit-ews: commit-queue-
Patch for laundry none

Description Andreas Kling 2013-09-24 08:10:54 PDT 
RenderBoxModelObject's continuation() does a hash lookup so calling it repeatedly is not super cool.
Comment 1 Andreas Kling 2013-09-24 08:16:13 PDT 
Created attachment 212468 [details]
Patch
Comment 2 Early Warning System Bot 2013-09-24 08:21:09 PDT 
Comment on attachment 212468 [details]
Patch

Attachment 212468 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1908496
Comment 3 Early Warning System Bot 2013-09-24 08:23:29 PDT 
Comment on attachment 212468 [details]
Patch

Attachment 212468 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/2004627
Comment 4 EFL EWS Bot 2013-09-24 08:25:14 PDT 
Comment on attachment 212468 [details]
Patch

Attachment 212468 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/2110241
Comment 5 EFL EWS Bot 2013-09-24 08:26:50 PDT 
Comment on attachment 212468 [details]
Patch

Attachment 212468 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/2004629
Comment 6 kov's GTK+ EWS bot 2013-09-24 08:30:37 PDT 
Comment on attachment 212468 [details]
Patch

Attachment 212468 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1960269
Comment 7 Geoffrey Garen 2013-09-24 08:36:56 PDT 
Comment on attachment 212468 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212468&action=review

r=me, plz fix build -- see below

> Source/WebCore/rendering/RenderInline.cpp:1439
> +            continuation->addFocusRingRects(rects, flooredLayoutPoint(additionalOffset + toRenderBox(continuation())->location() - containingBlock()->location()), paintContainer);

Nix the parens on 'continuation' here.
Comment 8 Build Bot 2013-09-24 08:45:23 PDT 
Comment on attachment 212468 [details]
Patch

Attachment 212468 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1908503
Comment 9 Andreas Kling 2013-09-24 08:46:24 PDT 
Created attachment 212471 [details]
Patch for laundry
Comment 10 WebKit Commit Bot 2013-09-24 09:19:08 PDT 
Comment on attachment 212471 [details]
Patch for laundry

Clearing flags on attachment: 212471

Committed r156334: <http://trac.webkit.org/changeset/156334>
Comment 11 WebKit Commit Bot 2013-09-24 09:19:11 PDT 
All reviewed patches have been landed.  Closing bug.