Bug 121840

Summary: Cache continuation() in a local to avoid repeat hash lookups.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, eflews.bot, esprehn+autocc, glenn, gtk-ews, gyuyoung.kim, kondapallykalyan, philn, rniwa, webkit-ews, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ggaren: review+, webkit-ews: commit-queue-
Patch for laundry none

Andreas Kling
Reported 2013-09-24 08:10:54 PDT
RenderBoxModelObject's continuation() does a hash lookup so calling it repeatedly is not super cool.
Attachments
Patch (6.41 KB, patch)
2013-09-24 08:16 PDT, Andreas Kling 		ggaren: review+
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Patch for laundry (6.41 KB, patch)
2013-09-24 08:46 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-09-24 08:16:13 PDT
Created attachment 212468 [details] Patch
Early Warning System Bot
Comment 2 2013-09-24 08:21:09 PDT
Comment on attachment 212468 [details] Patch Attachment 212468 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1908496
Early Warning System Bot
Comment 3 2013-09-24 08:23:29 PDT
Comment on attachment 212468 [details] Patch Attachment 212468 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/2004627
EFL EWS Bot
Comment 4 2013-09-24 08:25:14 PDT
Comment on attachment 212468 [details] Patch Attachment 212468 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/2110241
EFL EWS Bot
Comment 5 2013-09-24 08:26:50 PDT
Comment on attachment 212468 [details] Patch Attachment 212468 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/2004629
kov's GTK+ EWS bot
Comment 6 2013-09-24 08:30:37 PDT
Comment on attachment 212468 [details] Patch Attachment 212468 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1960269
Geoffrey Garen
Comment 7 2013-09-24 08:36:56 PDT
Comment on attachment 212468 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212468&action=review r=me, plz fix build -- see below > Source/WebCore/rendering/RenderInline.cpp:1439 > + continuation->addFocusRingRects(rects, flooredLayoutPoint(additionalOffset + toRenderBox(continuation())->location() - containingBlock()->location()), paintContainer); Nix the parens on 'continuation' here.
Build Bot
Comment 8 2013-09-24 08:45:23 PDT
Comment on attachment 212468 [details] Patch Attachment 212468 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1908503
Andreas Kling
Comment 9 2013-09-24 08:46:24 PDT
Created attachment 212471 [details] Patch for laundry
WebKit Commit Bot
Comment 10 2013-09-24 09:19:08 PDT
Comment on attachment 212471 [details] Patch for laundry Clearing flags on attachment: 212471 Committed r156334: <http://trac.webkit.org/changeset/156334>
WebKit Commit Bot
Comment 11 2013-09-24 09:19:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.