Bug 121832

Summary:

[CMake] Add precompiled header for MSVC in WebCore

Product:

WebKit

Reporter:

Patrick R. Gansterer <paroga>

Component:

Tools / Tests

Assignee:

Patrick R. Gansterer <paroga>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

achristensen, bfulgham, commit-queue, eflews.bot, gyuyoung.kim, rakuco

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	eflews.bot: commit-queue-
Patch	eflews.bot: commit-queue-
Patch	achristensen: review-

Patrick R. Gansterer

Reported 2013-09-24 03:26:07 PDT

[CMake] Add precompiled header for MSVC in WebCore

Attachments
Patch (2.34 KB, patch) 2013-09-24 03:28 PDT, Patrick R. Gansterer	eflews.bot: commit-queue-	Details Formatted Diff Diff
Patch (2.55 KB, patch) 2013-09-24 03:42 PDT, Patrick R. Gansterer	eflews.bot: commit-queue-	Details Formatted Diff Diff
Patch (2.77 KB, patch) 2013-09-24 03:49 PDT, Patrick R. Gansterer	achristensen: review-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Patrick R. Gansterer

Comment 1 2013-09-24 03:28:28 PDT

Created attachment 212445 [details] Patch

EFL EWS Bot

Comment 2 2013-09-24 03:32:39 PDT

Comment on attachment 212445 [details] Patch Attachment 212445 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/2053283

EFL EWS Bot

Comment 3 2013-09-24 03:32:56 PDT

Comment on attachment 212445 [details] Patch Attachment 212445 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/2012281

Patrick R. Gansterer

Comment 4 2013-09-24 03:42:47 PDT

Created attachment 212447 [details] Patch

EFL EWS Bot

Comment 5 2013-09-24 03:45:59 PDT

Comment on attachment 212447 [details] Patch Attachment 212447 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/2062244

EFL EWS Bot

Comment 6 2013-09-24 03:46:29 PDT

Comment on attachment 212447 [details] Patch Attachment 212447 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/2109192

Patrick R. Gansterer

Comment 7 2013-09-24 03:49:04 PDT

Created attachment 212448 [details] Patch

Gyuyoung Kim

Comment 8 2013-09-25 03:33:38 PDT

Comment on attachment 212448 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212448&action=review > Source/WebCore/ChangeLog:7 > + Description ? > Source/WebCore/WebCorePrefix.h:30 > +#ifdef BUILDING_WITH_CMAKE It seems to me that this cmakeconfig.h is included by all cmake ports, not only MSVC. Dont' you need to change bug title ? Or, need to mention it in ChangeLog ?

Alex Christensen

Comment 9 2015-12-09 23:50:00 PST

Comment on attachment 212448 [details] Patch This was done using the ADD_PRECOMPILED_HEADER macro in http://trac.webkit.org/changeset/182545 Once again, thanks for the early CMake work you did, Patrick. CMake is now the default build system for Windows.

Brent Fulgham

Comment 10 2015-12-10 08:47:17 PST

(In reply to comment #9) > Comment on attachment 212448 [details] > Patch > > This was done using the ADD_PRECOMPILED_HEADER macro in > http://trac.webkit.org/changeset/182545 > Once again, thanks for the early CMake work you did, Patrick. CMake is now > the default build system for Windows. Is this patch no longer needed? Why not close the bug?

Alex Christensen

Comment 11 2015-12-10 11:04:24 PST

*** This bug has been marked as a duplicate of bug 115944 ***

Note You need to log in before you can comment on or make changes to this bug.