Bug 121821

Summary: op_get_callee shouldn't use value profiling
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 121074    
Attachments:
Description Flags
Patch fpizlo: review+

Mark Hahnenberg
Reported 2013-09-23 20:01:48 PDT
Currently it's one of the two opcodes that uses m_singletonValue, which is unnecessary. Our current plan is to remove m_singletonValue so that GenGC can have a simpler story for handling CodeBlocks/FunctionExecutables during nursery collections.
Attachments
Patch (12.72 KB, patch)
2013-09-24 14:44 PDT, Mark Hahnenberg 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2013-09-24 14:44:50 PDT
Created attachment 212507 [details] Patch
Filip Pizlo
Comment 2 2013-09-24 14:47:27 PDT
Comment on attachment 212507 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212507&action=review r=me > Source/JavaScriptCore/runtime/Options.cpp:215 > - > + Revert.
Mark Hahnenberg
Comment 3 2013-09-24 17:36:47 PDT
Committed r156376: <http://trac.webkit.org/changeset/156376>
Note You need to log in before you can comment on or make changes to this bug.