Bug 121812

Summary:

Move style change analysis code to RenderElement

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, kondapallykalyan, philn, webkit-ews, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	kling: review+, webkit-ews: commit-queue-
another	none

Antti Koivisto

Reported 2013-09-23 16:58:12 PDT

Text renderers don't need this.

Attachments
patch (27.39 KB, patch) 2013-09-23 17:01 PDT, Antti Koivisto	kling: review+ webkit-ews: commit-queue-	Details Formatted Diff Diff
another (27.91 KB, patch) 2013-09-23 17:16 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2013-09-23 17:01:06 PDT

Andreas Kling

Comment 2 2013-09-23 17:05:36 PDT

Comment on attachment 212407 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=212407&action=review > Source/WebCore/rendering/RenderElement.h:66 > + enum StylePropagationType { PropagateAllChildren, PropagateBlockChildrenOnly }; Shouldn't this be PropagateToAllChildren / PropagateToBlockChildrenOnly?

Early Warning System Bot

Comment 3 2013-09-23 17:11:02 PDT

Early Warning System Bot

Comment 4 2013-09-23 17:13:29 PDT

Antti Koivisto

Comment 5 2013-09-23 17:16:58 PDT

Antti Koivisto

Comment 6 2013-09-23 17:55:09 PDT

Note You need to log in before you can comment on or make changes to this bug.