Bug 121793

Summary: Buildfix for non Mac platforms with enabled NetworkProcess
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, andersca, bdakin, benjamin, commit-queue, darin, enrica, hyatt, kling, mitz, mjs, mrowe, ossy, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 110141    
Attachments:
Description Flags
Patch
none
Patch none

Csaba Osztrogonác
Reported 2013-09-23 10:00:08 PDT
NetworkProcess build is still broken on non Mac platforms because of insufficient ifdefs. Patch is coming soon.
Attachments
Patch (8.63 KB, patch)
2013-09-23 10:23 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (8.85 KB, patch)
2013-09-24 05:48 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2013-09-23 10:23:47 PDT
Created attachment 212361 [details] Patch
Anders Carlsson
Comment 2 2013-09-23 14:02:50 PDT
Comment on attachment 212361 [details] Patch I don’t think this should be guarded with PLATFORM(MAC), it’s about whether shareable resources are enabled.
Csaba Osztrogonác
Comment 3 2013-09-24 04:56:24 PDT
(In reply to comment #2) > (From update of attachment 212361 [details]) > I don’t think this should be guarded with PLATFORM(MAC), it’s about whether shareable resources are enabled. There isn't any guard for enabling/disabling shareable resources. Should I add a new ifdef guard for it? Otherwise I don't understand what is the problem with the PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090 guard? As I pointed in the changelog, didReceiveResource is only used in WebKit2/NetworkProcess/AsynchronousNetworkLoaderClient.cpp inside the same guard. And didCacheResource is only used in WebKit2/NetworkProcess/mac/DiskCacheMonitor.mm inside the same guard. If PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090 condition is false, all code is unreachable what I proposed to guard. So what is your suggestion?
Csaba Osztrogonác
Comment 4 2013-09-24 05:48:13 PDT
Created attachment 212454 [details] Patch Let's try to add a new guard: ENABLE(SHAREABLE_RESOURCE) and enable it on Mac by default.
Csaba Osztrogonác
Comment 5 2013-09-27 04:17:14 PDT
(In reply to comment #4) > Created an attachment (id=212454) [details] > Patch > > Let's try to add a new guard: ENABLE(SHAREABLE_RESOURCE) and enable it on Mac by default. Anders, do you mean this kind of guarding?
Csaba Osztrogonác
Comment 6 2013-09-30 06:47:31 PDT
ping?
Csaba Osztrogonác
Comment 7 2013-10-07 07:55:23 PDT
Anders, could you review this new patch please?
Csaba Osztrogonác
Comment 8 2013-10-10 08:04:26 PDT
(In reply to comment #7) > Anders, could you review this new patch please? ping? I fixed immediately what you asked 2 weeks before. :(
Csaba Osztrogonác
Comment 9 2013-10-10 08:07:34 PDT
Adding more WK2 owner, maybe somebody have a little bit time for review.
WebKit Commit Bot
Comment 10 2013-10-10 08:33:32 PDT
Comment on attachment 212454 [details] Patch Clearing flags on attachment: 212454 Committed r157225: <http://trac.webkit.org/changeset/157225>
WebKit Commit Bot
Comment 11 2013-10-10 08:33:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.