Bug 121792

Summary: [iOS] Initialize settings mediaPlayback{AllowsInline, RequiresUserGesture} and shouldRespectImageOrientation as appropriate
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebCore Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, ddkilzer, joepeck
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
darin: review+
Patch darin: review+

Daniel Bates
Reported 2013-09-23 09:56:08 PDT
In contrast to other platform, we want to disable mediaPlaybackAllowsInline, and enable mediaPlaybackRequiresUserGesture and shouldRespectImageOrientation by default on iOS.
Attachments
Patch (3.68 KB, patch)
2013-09-23 09:58 PDT, Daniel Bates 		darin: review+
DetailsFormatted DiffDiff
Patch (3.99 KB, patch)
2013-09-23 17:06 PDT, Daniel Bates 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2013-09-23 09:58:06 PDT
Created attachment 212359 [details] Patch
Darin Adler
Comment 2 2013-09-23 10:00:56 PDT
Comment on attachment 212359 [details] Patch I don’t think the ForPlatform suffixes add much clarity. I also think this approach is awkward. But seems OK.
Daniel Bates
Comment 3 2013-09-23 10:59:37 PDT
(In reply to comment #2) > (From update of attachment 212359 [details]) > I don’t think the ForPlatform suffixes add much clarity. I also think this approach is awkward. But seems OK. I am open to ideas/suggestions on a better approach. For now, I'll drop the "ForPlatform" suffixes.
Daniel Bates
Comment 4 2013-09-23 17:06:21 PDT
Created attachment 212410 [details] Patch I've updated the patch to add constants whose definition is conditioned on whether we are building for iOS instead of adding functions. I choose this to approach to help make the code in Settings.cpp more readable by minimizing both the number of added #ifdef guards and lines of code. Let me know if there is a better way to define an iOS-specific default value for a setting.
Daniel Bates
Comment 5 2013-09-24 10:11:28 PDT
Committed r156337: <http://trac.webkit.org/changeset/156337>
Note You need to log in before you can comment on or make changes to this bug.