Bug 121784

Summary:

Rename RenderObject::first/lastChild to RenderObject::first/lastChildSlow

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

philn, webkit-ews, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	webkit-ews: commit-queue-
another	kling: review+, webkit-ews: commit-queue-
yet another	webkit-ews: commit-queue-
yet yet another	none

Antti Koivisto

Reported 2013-09-23 05:13:39 PDT

This will make it obvious in code where typing should be tightened.

Attachments
patch (49.27 KB, patch) 2013-09-23 10:53 PDT, Antti Koivisto	webkit-ews: commit-queue-	Details Formatted Diff Diff
another (49.27 KB, patch) 2013-09-23 11:06 PDT, Antti Koivisto	kling: review+ webkit-ews: commit-queue-	Details Formatted Diff Diff
yet another (50.83 KB, patch) 2013-09-23 11:24 PDT, Antti Koivisto	webkit-ews: commit-queue-	Details Formatted Diff Diff
yet yet another (51.70 KB, patch) 2013-09-23 11:41 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2013-09-23 10:53:27 PDT

Created attachment 212366 [details] patch

Early Warning System Bot

Comment 2 2013-09-23 10:59:55 PDT

Comment on attachment 212366 [details] patch Attachment 212366 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/2053161

Andreas Kling

Comment 3 2013-09-23 11:04:08 PDT

Comment on attachment 212366 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=212366&action=review I guess we can and should tighten all these things, but here's some whining anyway: > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:328 > - return renderer->firstChild() && renderer->firstChild()->isInlineElementContinuation(); > + return renderer->firstChildSlow() && renderer->firstChildSlow()->isInlineElementContinuation(); Should we cache it in a local here to avoid double virtual dispatch? > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:370 > - return renderer->lastChild() && isInlineWithContinuation(renderer->lastChild()); > + return renderer->lastChildSlow() && isInlineWithContinuation(renderer->lastChildSlow()); And here. > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:464 > - if (firstChild == parent->firstChild()) > + if (firstChild == parent->firstChildSlow()) > break; > - firstChild = parent->firstChild(); > + firstChild = parent->firstChildSlow(); Also here. > Source/WebCore/dom/ContainerNode.cpp:898 > - if (o->firstChild()) > - o = o->firstChild(); > + if (o->firstChildSlow()) > + o = o->firstChildSlow(); etc. > Source/WebCore/dom/ContainerNode.cpp:958 > - if (o->lastChild()) > - o = o->lastChild(); > + if (o->lastChildSlow()) > + o = o->lastChildSlow(); etc. > Source/WebCore/rendering/RenderBlock.cpp:1081 > - if (prev && prev->firstChild() && prev->firstChild()->isInline() && prev->firstChild()->isRunIn()) > + if (prev && prev->firstChildSlow() && prev->firstChildSlow()->isInline() && prev->firstChildSlow()->isRunIn()) Oh here.

Early Warning System Bot

Comment 4 2013-09-23 11:05:24 PDT

Comment on attachment 212366 [details] patch Attachment 212366 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/2053164

Antti Koivisto

Comment 5 2013-09-23 11:06:07 PDT

Created attachment 212368 [details] another

Andreas Kling

Comment 6 2013-09-23 11:07:20 PDT

Comment on attachment 212368 [details] another r=me

Early Warning System Bot

Comment 7 2013-09-23 11:12:43 PDT

Comment on attachment 212368 [details] another Attachment 212368 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/2118005