Bug 121768

Summary: CTTE: RenderNamedFlowThread and FlowThreadController should operate on Elements, not Nodes
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, commit-queue, esprehn+autocc, glenn, kangil.han, kondapallykalyan, mmaerean, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+

Sam Weinig
Reported 2013-09-22 14:01:29 PDT
CTTE: RenderNamedFlowThread and FlowThreadController should operate on Elements, not Nodes
Attachments
Patch (27.75 KB, patch)
2013-09-22 14:07 PDT, Sam Weinig 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2013-09-22 14:07:52 PDT
Created attachment 212306 [details] Patch
Andreas Kling
Comment 2 2013-09-22 14:15:26 PDT
Comment on attachment 212306 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212306&action=review r=me > Source/WebCore/rendering/RenderNamedFlowThread.cpp:556 > +static bool isContainedInElements(Vector<Element*> others, Element* element) 'others' should be a const reference, we are making a silly copy here.
Sam Weinig
Comment 3 2013-09-22 14:22:32 PDT
Committed r156250: <http://trac.webkit.org/changeset/156250>
Mihai Maerean
Comment 4 2013-10-07 06:02:57 PDT
According to the CSS Regions Specification (http://dev.w3.org/csswg/css-regions/#the-flow-into-property), you can collect nodes (not just elements) into a flow thread. This bug is invalid. The named flow thread below will only contain a text node, the child of the div marked .content. <style> .content { flow-into:flow content; } .region { flow-from:flow; } </style> <div class="content">some text</div> <div class="region"></div>
Note You need to log in before you can comment on or make changes to this bug.