Bug 121745

Summary: Don't bloat Obj-C bindings with inlined attribute retrieval.
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore Misc.Assignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin, jonlee
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch idea none

Andreas Kling
Reported 2013-09-21 09:53:30 PDT
fastGetAttribute() is overkill here.
Attachments
Patch idea (1.59 KB, patch)
2013-09-21 09:54 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-09-21 09:54:06 PDT
Created attachment 212275 [details] Patch idea
WebKit Commit Bot
Comment 2 2013-09-21 11:45:02 PDT
Comment on attachment 212275 [details] Patch idea Clearing flags on attachment: 212275 Committed r156232: <http://trac.webkit.org/changeset/156232>
WebKit Commit Bot
Comment 3 2013-09-21 11:45:04 PDT
All reviewed patches have been landed. Closing bug.
Jon Lee
Comment 4 2013-09-21 17:10:47 PDT
Changing the binding output should also include change expected test results. Fixed in http://trac.webkit.org/changeset/156236
Darin Adler
Comment 5 2013-09-21 20:30:10 PDT
Is fastGetAttribute inlined!? I didn’t realize!
Note You need to log in before you can comment on or make changes to this bug.