Bug 121741 – Web Inspector: show resource request initiator in the details sidebar

• Component: Web Inspector
• Status: RESOLVED FIXED

[Timothy Hatcher]

We should show the initiator into in the resource details sidebar.

<rdar://problem/5334051>

[Timothy Hatcher]

Created attachment 212263 [details]
Patch

[Timothy Hatcher]

Created attachment 212264 [details]
Screenshot

[Joseph Pecoraro]

Comment on attachment 212263 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212263&action=review

r=me

> Source/WebInspectorUI/UserInterface/FrameResourceManager.js:464
> +            for (var i = 0; i < stackTracePayload.length; ++i) {
> +                var callFramePayload = stackTracePayload[i];
> +                if (!callFramePayload.url || callFramePayload.url === "[native code]")
> +                    continue;
> +
> +                url = callFramePayload.url;
> +
> +                // The lineNumber is 1-based, but we expect 0-based.
> +                lineNumber = callFramePayload.lineNumber - 1;
> +
> +                columnNumber = callFramePayload.columnNumber;

Do you want to "break;" here? I would expect that you would want to show the latest stack frame info.

[Timothy Hatcher]

Comment on attachment 212263 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212263&action=review

>> Source/WebInspectorUI/UserInterface/FrameResourceManager.js:464
>> +                columnNumber = callFramePayload.columnNumber;
> 
> Do you want to "break;" here? I would expect that you would want to show the latest stack frame info.

Yes, good catch!

[Timothy Hatcher]

http://trac.webkit.org/changeset/156284