Bug 121737

Summary: Get rid of IsInlinedCodeTag and its associated methods since it's unused
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch
none
the patch sam: review+

Filip Pizlo
Reported 2013-09-21 00:00:42 PDT
Nobody sets IsInlinedCodeTag so any code that checks it is dead.
Attachments
the patch (4.40 KB, patch)
2013-09-21 00:01 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (11.83 KB, patch)
2013-09-21 01:02 PDT, Filip Pizlo 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-09-21 00:01:33 PDT
Created attachment 212258 [details] the patch
Geoffrey Garen
Comment 2 2013-09-21 00:25:37 PDT
Comment on attachment 212258 [details] the patch r=me
Filip Pizlo
Comment 3 2013-09-21 00:26:45 PDT
(In reply to comment #2) > (From update of attachment 212258 [details]) > r=me Heh, in the process of trying to convince myself that this was right, I found a bug. I will have another patch shortly.
Filip Pizlo
Comment 4 2013-09-21 01:02:26 PDT
Created attachment 212262 [details] the patch This does the same thing as the other patch, but also fixes a bug.
Filip Pizlo
Comment 5 2013-09-21 01:03:05 PDT
Comment on attachment 212262 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=212262&action=review > Source/JavaScriptCore/ChangeLog:37 > +2013-09-21 Filip Pizlo <fpizlo@apple.com> > + > + > + Reviewed by NOBODY (OOPS!). > + > + * interpreter/CallFrame.h: > + * interpreter/CallFrameInlines.h: > + * runtime/Arguments.cpp: > + (JSC::Arguments::tearOff): > + I will revert this.
Geoffrey Garen
Comment 6 2013-09-21 10:14:10 PDT
Ha, nice.
Filip Pizlo
Comment 7 2013-09-21 10:40:04 PDT
Landed in http://trac.webkit.org/changeset/156229
Note You need to log in before you can comment on or make changes to this bug.