Bug 121734

Summary: Never use ReturnPC for exception handling and quit using exception check indices as a lame replica of the CodeOrigin index
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, commit-queue, ggaren, gyuyoung.kim, mark.lam, mhahnenberg, msaboff, oliver, rakuco, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 121755, 121766    
Bug Blocks: 121641    
Attachments:
Description Flags
almost there
none
the patch mhahnenberg: review+

Filip Pizlo
Reported 2013-09-20 23:11:20 PDT
Patch forthcoming.
Attachments
almost there (37.62 KB, patch)
2013-09-22 21:17 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (56.93 KB, patch)
2013-09-23 12:17 PDT, Filip Pizlo 		mhahnenberg: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-09-22 21:17:43 PDT
Created attachment 212321 [details] almost there Still need to, like, compile it.
Filip Pizlo
Comment 2 2013-09-23 12:17:38 PDT
Created attachment 212378 [details] the patch
WebKit Commit Bot
Comment 3 2013-09-23 12:21:36 PDT
Attachment 212378 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/Target.pri', u'Source/JavaScriptCore/bytecode/CodeBlock.cpp', u'Source/JavaScriptCore/bytecode/CodeBlock.h', u'Source/JavaScriptCore/bytecode/CodeOrigin.h', u'Source/JavaScriptCore/bytecode/InlineCallFrameSet.cpp', u'Source/JavaScriptCore/bytecode/InlineCallFrameSet.h', u'Source/JavaScriptCore/dfg/DFGArgumentsSimplificationPhase.cpp', u'Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp', u'Source/JavaScriptCore/dfg/DFGCommonData.cpp', u'Source/JavaScriptCore/dfg/DFGCommonData.h', u'Source/JavaScriptCore/dfg/DFGDesiredWriteBarriers.cpp', u'Source/JavaScriptCore/dfg/DFGDesiredWriteBarriers.h', u'Source/JavaScriptCore/dfg/DFGGraph.cpp', u'Source/JavaScriptCore/dfg/DFGGraph.h', u'Source/JavaScriptCore/dfg/DFGJITCompiler.cpp', u'Source/JavaScriptCore/dfg/DFGJITCompiler.h', u'Source/JavaScriptCore/dfg/DFGOperations.cpp', u'Source/JavaScriptCore/dfg/DFGOperations.h', u'Source/JavaScriptCore/dfg/DFGRepatch.cpp', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp', u'Source/JavaScriptCore/dfg/DFGVirtualRegisterAllocationPhase.cpp', u'Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp', u'Source/JavaScriptCore/jit/AssemblyHelpers.h']" exit_code: 1 Source/JavaScriptCore/dfg/DFGCommonData.h:73: The parameter name "codeOrigin" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Hahnenberg
Comment 4 2013-09-23 12:32:03 PDT
Comment on attachment 212378 [details] the patch r=me
Filip Pizlo
Comment 5 2013-09-23 15:08:46 PDT
Landed in http://trac.webkit.org/changeset/156300
Note You need to log in before you can comment on or make changes to this bug.