Bug 121721

Summary:

Shaders that fail to compile should be marked as such

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

WebGL

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, kondapallykalyan, noam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	simon.fraser: review+

Description Dean Jackson 2013-09-20 14:59:48 PDT

We expect all output from ANGLE to pass compilation via glCompileShader. Currently we have some test cases that still fail compilation. We'll fix that, but in the meantime we should make sure that we do mark uncompilable shaders as an error.

Comment 1 Radar WebKit Bug Importer 2013-09-20 15:00:24 PDT

<rdar://problem/15044901>

Comment 2 Dean Jackson 2013-09-20 15:09:02 PDT

Created attachment 212228 [details]
Patch

Comment 3 Dean Jackson 2013-09-20 15:16:16 PDT

Committed r156205: <http://trac.webkit.org/changeset/156205>