Bug 121707

Summary: Refactoring LineBreaker and RenderTextInfo out of RenderBlock.h
Product: WebKit Reporter: Zoltan Horvath <zoltan>
Component: WebCore Misc.Assignee: Zoltan Horvath <zoltan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 121261    
Attachments:
Description Flags
proposed patch none

Zoltan Horvath
Reported 2013-09-20 13:08:04 PDT
LineBreaker and RenderTextInfo are defined in RenderBlock.h, but only used in RenderBlockLineLayout.cpp. Moving them there (LineBreaker needs to be a friend class of RenderBlock) in the first step in the process of refactoring LineBreaker::NextSegmentBreak into more manageable chunks.
Attachments
proposed patch (10.07 KB, patch)
2013-09-20 13:14 PDT, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2013-09-20 13:14:30 PDT
Created attachment 212211 [details] proposed patch
Dave Hyatt
Comment 2 2013-09-20 13:53:45 PDT
Comment on attachment 212211 [details] proposed patch r=me
WebKit Commit Bot
Comment 3 2013-09-20 14:16:45 PDT
Comment on attachment 212211 [details] proposed patch Clearing flags on attachment: 212211 Committed r156199: <http://trac.webkit.org/changeset/156199>
WebKit Commit Bot
Comment 4 2013-09-20 14:16:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.