Bug 121696

Summary:

Add an argument to ImageSource::createFrameAtIndex to hint a decoder that we expect a scaled image.

Product:

WebKit

Reporter:

Yongjun Zhang <yongjun_zhang>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ddkilzer, joepeck, koivisto, yongjun_zhang

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
add scale to hint platform decoders that we expect a scaled image.	none

Yongjun Zhang

Reported 2013-09-20 10:54:46 PDT

Some platform image decoders have the capability to decode an image in different scale levels. If we are going to paint an image in scaled down size, we can hint the decoder to give the image in the right scale to save some memory.

Attachments
add scale to hint platform decoders that we expect a scaled image. (2.89 KB, patch) 2013-09-20 11:16 PDT, Yongjun Zhang	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Yongjun Zhang

Comment 1 2013-09-20 11:16:00 PDT

Created attachment 212197 [details] add scale to hint platform decoders that we expect a scaled image.

Antti Koivisto

Comment 2 2013-09-20 11:35:36 PDT

Comment on attachment 212197 [details] add scale to hint platform decoders that we expect a scaled image. View in context: https://bugs.webkit.org/attachment.cgi?id=212197&action=review > Source/WebCore/platform/graphics/ImageSource.h:148 > + PassNativeImagePtr createFrameAtIndex(size_t, float* scale = 0); It is not clear if this scale parameter is input, output or both. Maybe a more descriptive name would help?

WebKit Commit Bot

Comment 3 2013-09-20 13:34:34 PDT

Comment on attachment 212197 [details] add scale to hint platform decoders that we expect a scaled image. Clearing flags on attachment: 212197 Committed r156195: <http://trac.webkit.org/changeset/156195>

WebKit Commit Bot

Comment 4 2013-09-20 13:34:36 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.