Bug 121692

Summary:

Move layer hierarchy functions from RenderObject to RenderElement

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa, simon.fraser, webkit-ews

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
patch 2	webkit-ews: commit-queue-
patch 3	buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion	none
remember to call base class versions of virtual functions	kling: review+

Antti Koivisto

Reported 2013-09-20 10:01:04 PDT

Text renderers don't need them.

Attachments
patch (16.65 KB, patch) 2013-09-20 10:08 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch 2 (17.89 KB, patch) 2013-09-20 10:16 PDT, Antti Koivisto	webkit-ews: commit-queue-	Details Formatted Diff Diff
patch 3 (17.91 KB, patch) 2013-09-20 10:26 PDT, Antti Koivisto	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (921.61 KB, application/zip) 2013-09-20 11:43 PDT, Build Bot	no flags	Details
remember to call base class versions of virtual functions (18.01 KB, patch) 2013-09-20 12:01 PDT, Antti Koivisto	kling: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2013-09-20 10:08:39 PDT

Created attachment 212186 [details] patch

Antti Koivisto

Comment 2 2013-09-20 10:16:48 PDT

Created attachment 212187 [details] patch 2

Early Warning System Bot

Comment 3 2013-09-20 10:24:44 PDT

Comment on attachment 212187 [details] patch 2 Attachment 212187 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1803322

Early Warning System Bot

Comment 4 2013-09-20 10:26:25 PDT

Comment on attachment 212187 [details] patch 2 Attachment 212187 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1803323

Antti Koivisto

Comment 5 2013-09-20 10:26:41 PDT

Created attachment 212193 [details] patch 3

Build Bot

Comment 6 2013-09-20 11:43:26 PDT

Comment on attachment 212193 [details] patch 3 Attachment 212193 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1900364 New failing tests: fast/regions/named-flow-content-order-2.html fast/block/positioning/absolute-appended-to-inline.html editing/inserting/line-break.html fast/regions/webkit-flow-renderer.html editing/inserting/5058163-1.html editing/inserting/5418891.html fast/regions/named-flow-content-order-1.html editing/inserting/insert-paragraph-03.html editing/inserting/insert-3800346-fix.html editing/inserting/insert-br-004.html

Build Bot

Comment 7 2013-09-20 11:43:28 PDT

Created attachment 212201 [details] Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Antti Koivisto

Comment 8 2013-09-20 12:01:36 PDT

Created attachment 212202 [details] remember to call base class versions of virtual functions

Andreas Kling

Comment 9 2013-09-20 12:44:16 PDT

Comment on attachment 212202 [details] remember to call base class versions of virtual functions View in context: https://bugs.webkit.org/attachment.cgi?id=212202&action=review r=me > Source/WebCore/rendering/RenderElement.cpp:203 > + newObject = 0; nullptr > Source/WebCore/rendering/RenderElement.cpp:263 > + return 0; nullptr > Source/WebCore/rendering/RenderElement.cpp:315 > + RenderLayer* layer = 0; nullptr > Source/WebCore/rendering/RenderElement.cpp:334 > + RenderLayer* layer = 0; nullptr > Source/WebCore/rendering/RenderElement.cpp:336 > + if ((layer = parent()->enclosingLayer())) Extra () pair here.

Antti Koivisto

Comment 10 2013-09-20 12:59:45 PDT

https://trac.webkit.org/r156190

Antti Koivisto

Comment 11 2013-09-20 13:00:07 PDT

> Extra () pair here. They are needed.

Darin Adler

Comment 12 2013-09-20 20:06:57 PDT

Comment on attachment 212202 [details] remember to call base class versions of virtual functions View in context: https://bugs.webkit.org/attachment.cgi?id=212202&action=review >> Source/WebCore/rendering/RenderElement.cpp:336 >> + if ((layer = parent()->enclosingLayer())) > > Extra () pair here. You need that extra () to tell the compiler that you mean this as an assignment, not an == test. It turns off the warning.

Note You need to log in before you can comment on or make changes to this bug.