Summary: | [Qt] Crash when trying to download blob URL | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Allan Sandfeld Jensen <allan.jensen> | ||||
Component: | Page Loading | Assignee: | Allan Sandfeld Jensen <allan.jensen> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abrhm, commit-queue, hausmann, jturcotte, kadam, ossy, zarvai | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Allan Sandfeld Jensen
2013-09-20 07:41:06 PDT
Created attachment 212163 [details]
Patch
Attachment 212163 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/qt/TestExpectations', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/network/qt/ResourceRequestQt.cpp', u'Source/WebKit/qt/ChangeLog', u'Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp']" exit_code: 1
Source/WebCore/platform/network/qt/ResourceRequestQt.cpp:65: One line control clauses should not use braces. [whitespace/braces] [4]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 212163 [details] Patch Clearing flags on attachment: 212163 Committed r156330: <http://trac.webkit.org/changeset/156330> All reviewed patches have been landed. Closing bug. (In reply to comment #3) > (From update of attachment 212163 [details]) > Clearing flags on attachment: 212163 > > Committed r156330: <http://trac.webkit.org/changeset/156330> FYI: It broke the !ENABLE(BLOB) builds. (In reply to comment #5) > (In reply to comment #3) > > (From update of attachment 212163 [details] [details]) > > Clearing flags on attachment: 212163 > > > > Committed r156330: <http://trac.webkit.org/changeset/156330> > > FYI: It broke the !ENABLE(BLOB) builds. Thanks for the warning. I will try to fix it tomorrow. |