Bug 121677

Summary: Modified img src and srcset encoded URL tests
Product: WebKit Reporter: Yoav Weiss <yoav>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Yoav Weiss
Reported 2013-09-20 06:43:58 PDT
Modified img src and srcset encoded URL tests
Attachments
Patch (6.20 KB, patch)
2013-09-20 06:45 PDT, Yoav Weiss 		no flags
DetailsFormatted DiffDiff
Patch (6.21 KB, patch)
2013-09-20 06:51 PDT, Yoav Weiss 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.21 KB, patch)
2013-09-20 07:08 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yoav Weiss
Comment 1 2013-09-20 06:45:03 PDT
Created attachment 212158 [details] Patch
Yoav Weiss
Comment 2 2013-09-20 06:47:02 PDT
Previous encoded URL tests for img's src and srcset have broken the Windows builds, since '?' is not a valid char. Moved them to using '@' instead.
WebKit Commit Bot
Comment 3 2013-09-20 06:47:56 PDT
Attachment 212158 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/hidpi/image-srcset-encoded-expected.txt', u'LayoutTests/fast/hidpi/image-srcset-encoded.html', u'LayoutTests/fast/hidpi/image-srcset-question-mark-expected.txt', u'LayoutTests/fast/hidpi/image-srcset-question-mark.html', u'LayoutTests/fast/hidpi/resources/image?test.png', u'LayoutTests/fast/hidpi/resources/image@test.png', u'LayoutTests/fast/loader/image-src-encoded-expected.txt', u'LayoutTests/fast/loader/image-src-question-mark-expected.txt', u'LayoutTests/fast/loader/resources/image?test.png', u'LayoutTests/fast/loader/resources/image@test.png']" exit_code: 1 LayoutTests/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] LayoutTests/ChangeLog:7: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yoav Weiss
Comment 4 2013-09-20 06:51:49 PDT
Created attachment 212159 [details] Patch
Patrick R. Gansterer
Comment 5 2013-09-20 07:08:43 PDT
Created attachment 212160 [details] Patch for landing
WebKit Commit Bot
Comment 6 2013-09-20 07:42:10 PDT
Comment on attachment 212160 [details] Patch for landing Clearing flags on attachment: 212160 Committed r156161: <http://trac.webkit.org/changeset/156161>
WebKit Commit Bot
Comment 7 2013-09-20 07:42:13 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 8 2013-09-20 10:28:12 PDT
This patch lacked one of updated files, fixed in <http://trac.webkit.org/r156179>.
Note You need to log in before you can comment on or make changes to this bug.