Bug 121645

Summary: Counter shouldn't invalidate the tree in the middle of layout
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: commit-queue, dbates, esprehn+autocc, glenn, hyatt, jchaffraix, kondapallykalyan, simon.fraser, thorton, zalan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixes the bug
none
Updated for ToT dbates: review-

Ryosuke Niwa
Reported 2013-09-19 16:25:55 PDT
Counter shouldn't invalidate the tree in the middle of layout
Attachments
Fixes the bug (7.15 KB, patch)
2013-09-19 16:45 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Updated for ToT (7.15 KB, patch)
2013-09-19 16:48 PDT, Ryosuke Niwa 		dbates: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-09-19 16:45:39 PDT
Created attachment 212107 [details] Fixes the bug
Ryosuke Niwa
Comment 2 2013-09-19 16:48:25 PDT
Created attachment 212108 [details] Updated for ToT
Simon Fraser (smfr)
Comment 3 2013-09-23 11:59:55 PDT
Comment on attachment 212108 [details] Updated for ToT View in context: https://bugs.webkit.org/attachment.cgi?id=212108&action=review > Source/WebCore/page/FrameView.cpp:2867 > + for (RenderObject* renderer = view; renderer; renderer = renderer->nextInPreOrder()) { > + if (!renderer->isCounter()) > + continue; > + > + static_cast<RenderCounter*>(renderer)->updateCounter(); > + } We walk the entire render tree to update counters? That's crazy! We should keep a hash set of counter renderers.
Daniel Bates
Comment 4 2016-04-23 12:18:03 PDT
Comment on attachment 212108 [details] Updated for ToT r- by comment #3.
Ryosuke Niwa
Comment 5 2016-04-23 21:12:13 PDT
I'm not working on this.
Note You need to log in before you can comment on or make changes to this bug.