Bug 121645

Summary: Counter shouldn't invalidate the tree in the middle of layout
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: commit-queue, dbates, esprehn+autocc, glenn, hyatt, jchaffraix, kondapallykalyan, simon.fraser, thorton, zalan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixes the bug
none
Updated for ToT dbates: review-

Description Ryosuke Niwa 2013-09-19 16:25:55 PDT 
Counter shouldn't invalidate the tree in the middle of layout
Comment 1 Ryosuke Niwa 2013-09-19 16:45:39 PDT 
Created attachment 212107 [details]
Fixes the bug
Comment 2 Ryosuke Niwa 2013-09-19 16:48:25 PDT 
Created attachment 212108 [details]
Updated for ToT
Comment 3 Simon Fraser (smfr) 2013-09-23 11:59:55 PDT 
Comment on attachment 212108 [details]
Updated for ToT

View in context: https://bugs.webkit.org/attachment.cgi?id=212108&action=review

> Source/WebCore/page/FrameView.cpp:2867
> +    for (RenderObject* renderer = view; renderer; renderer = renderer->nextInPreOrder()) {
> +        if (!renderer->isCounter())
> +            continue;
> +
> +        static_cast<RenderCounter*>(renderer)->updateCounter();
> +    }

We walk the entire render tree to update counters? That's crazy! We should keep a hash set of counter renderers.
Comment 4 Daniel Bates 2016-04-23 12:18:03 PDT 
Comment on attachment 212108 [details]
Updated for ToT

r- by comment #3.
Comment 5 Ryosuke Niwa 2016-04-23 21:12:13 PDT 
I'm not working on this.