Bug 121638

Summary: Add covariant RenderElement* Element::renderer()
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, eflews.bot, gtk-ews, gyuyoung.kim, ossy, philn, rego+ews, rniwa, webkit-ews, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 121640    
Bug Blocks:    
Attachments:
Description Flags
patch
kling: review+, webkit-ews: commit-queue-
for bots
none
another
none
yet another none

Antti Koivisto
Reported 2013-09-19 14:24:20 PDT
Tighter typing.
Attachments
patch (10.90 KB, patch)
2013-09-19 14:28 PDT, Antti Koivisto 		kling: review+
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
for bots (12.80 KB, patch)
2013-09-20 01:22 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
another (13.28 KB, patch)
2013-09-20 01:42 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
yet another (13.77 KB, patch)
2013-09-20 01:51 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2013-09-19 14:28:57 PDT
Created attachment 212096 [details] patch
Andreas Kling
Comment 2 2013-09-19 14:37:04 PDT
Comment on attachment 212096 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=212096&action=review > Source/WebCore/ChangeLog:3 > + Add covariant RenderElement* ContainerNode::renderer() ContainerNode -> RenderElement -> Element This is pretty weird-looking. :)
Early Warning System Bot
Comment 3 2013-09-19 14:40:44 PDT
Comment on attachment 212096 [details] patch Attachment 212096 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1955236
Early Warning System Bot
Comment 4 2013-09-19 14:44:57 PDT
Comment on attachment 212096 [details] patch Attachment 212096 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1949289
EFL EWS Bot
Comment 5 2013-09-19 14:59:45 PDT
Comment on attachment 212096 [details] patch Attachment 212096 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1999166
Build Bot
Comment 6 2013-09-19 15:07:24 PDT
Comment on attachment 212096 [details] patch Attachment 212096 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1949293
Build Bot
Comment 7 2013-09-19 15:28:00 PDT
Comment on attachment 212096 [details] patch Attachment 212096 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1999168
EFL EWS Bot
Comment 8 2013-09-19 15:33:30 PDT
Comment on attachment 212096 [details] patch Attachment 212096 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/2010018
Build Bot
Comment 9 2013-09-19 18:10:45 PDT
Comment on attachment 212096 [details] patch Attachment 212096 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/1867300
kov's GTK+ EWS bot
Comment 10 2013-09-19 18:37:07 PDT
Comment on attachment 212096 [details] patch Attachment 212096 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1959039
Antti Koivisto
Comment 11 2013-09-20 01:22:13 PDT
Created attachment 212130 [details] for bots
Antti Koivisto
Comment 12 2013-09-20 01:23:54 PDT
(In reply to comment #2) > (From update of attachment 212096 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=212096&action=review > > > Source/WebCore/ChangeLog:3 > > + Add covariant RenderElement* ContainerNode::renderer() > > ContainerNode -> RenderElement -> Element > This is pretty weird-looking. :) Moved it to RenderElement* Element::renderer() which makes more sense. While all ContainerNode renderers are RenderElements it makes more semantic sense to have it in Element. ContainerNode is not that popular of a type.
Antti Koivisto
Comment 13 2013-09-20 01:42:53 PDT
Created attachment 212132 [details] another
Antti Koivisto
Comment 14 2013-09-20 01:51:11 PDT
Created attachment 212134 [details] yet another
Antti Koivisto
Comment 15 2013-09-20 01:58:39 PDT
https://trac.webkit.org/r156144
Csaba Osztrogonác
Comment 16 2013-09-20 03:59:20 PDT
(In reply to comment #15) > https://trac.webkit.org/r156144 and the Windows buildfix landed in http://trac.webkit.org/changeset/156148
Note You need to log in before you can comment on or make changes to this bug.