Bug 121596

Summary: [CTTE] RenderText is always anonymous or associated with Text node
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
with updated mathml test results kling: review+

Antti Koivisto
Reported 2013-09-19 01:06:09 PDT
Tighten until it snaps
Attachments
patch (37.55 KB, patch)
2013-09-19 01:28 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
with updated mathml test results (123.95 KB, patch)
2013-09-19 02:12 PDT, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2013-09-19 01:28:18 PDT
Created attachment 212042 [details] patch
Antti Koivisto
Comment 2 2013-09-19 02:12:23 PDT
Created attachment 212043 [details] with updated mathml test results
Andreas Kling
Comment 3 2013-09-19 03:22:00 PDT
Comment on attachment 212043 [details] with updated mathml test results View in context: https://bugs.webkit.org/attachment.cgi?id=212043&action=review > Source/WebCore/rendering/RenderCounter.h:50 > + RenderCounter(const CounterContent&); explicit > Source/WebCore/rendering/RenderQuote.h:39 > + RenderQuote(QuoteType); explicit > Source/WebCore/rendering/RenderText.cpp:166 > - view().frameView().incrementVisuallyNonEmptyCharacterCount(m_text.length()); > + if (textNode) > + view().frameView().incrementVisuallyNonEmptyCharacterCount(m_text.length()); This is so ugly. I wish we had alternate constructors for this kind of thing, so view() is always guaranteed to work.
Antti Koivisto
Comment 4 2013-09-19 03:37:47 PDT
http://trac.webkit.org/changeset/156090
Note You need to log in before you can comment on or make changes to this bug.