Bug 121591

Summary: REGRESSION (r149928): CanvasStyle::operator= leaks everything
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: DOMAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, esprehn+autocc, kling
Priority: P2 Keywords: InRadar, Regression
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed fix none

Alexey Proskuryakov
Reported 2013-09-19 00:32:55 PDT
There is a reason why dirty tricks are not advisable, and the reason is that they are difficult to get right :)
Attachments
proposed fix (1.48 KB, patch)
2013-09-19 00:35 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2013-09-19 00:35:43 PDT
Created attachment 212038 [details] proposed fix Just fix the leak. It would be nice to make the code less unusual at some point.
Alexey Proskuryakov
Comment 2 2013-09-19 00:36:34 PDT
(this leak is very visible on leaks bot, not just theoretical)
Andreas Kling
Comment 3 2013-09-19 06:04:18 PDT
Comment on attachment 212038 [details] proposed fix :|
WebKit Commit Bot
Comment 4 2013-09-19 08:59:32 PDT
Comment on attachment 212038 [details] proposed fix Clearing flags on attachment: 212038 Committed r156099: <http://trac.webkit.org/changeset/156099>
WebKit Commit Bot
Comment 5 2013-09-19 08:59:34 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 6 2013-09-19 09:37:44 PDT
<rdar://problem/15031018>
Note You need to log in before you can comment on or make changes to this bug.