Summary: | [SVG] Handle endEvent for svg animations | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||||
Component: | SVG | Assignee: | Antoine Quint <graouts> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | adauria, commit-queue, dino, graouts, jonlee, krit, sabouhallawa, thorton, webkit-bug-importer, zimmermann | ||||||||
Priority: | P2 | Keywords: | BlinkMergeCandidate, InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Ryosuke Niwa
2013-09-18 20:38:19 PDT
Created attachment 262882 [details]
Simple testcase
Created attachment 262886 [details]
Patch
Comment on attachment 262886 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262886&action=review > Source/WebCore/svg/animation/SMILTimeContainer.cpp:272 > AnimationsVector* scheduled = it.value.get(); > + unsigned size = scheduled->size(); > + for (unsigned n = 0; n < size; n++) { > + SVGSMILElement* animation = scheduled->at(n); > + if (!animation->hasConditionsConnected()) > + animation->connectConditions(); > + } I think you can use a modern for loop here. for (auto* animation : scheduled) { if (!animation->hasConditionsConnected()) animation->connectConditions(); } While here, we can come up with a better variable name than "it". > Source/WebCore/svg/animation/SMILTimeContainer.cpp:276 > + for (auto& it : m_scheduledAnimations) { > + AnimationsVector* scheduled = it.value.get(); Same here about the variable name. Created attachment 262918 [details]
Patch for landing
Comment on attachment 262918 [details] Patch for landing Clearing flags on attachment: 262918 Committed r190890: <http://trac.webkit.org/changeset/190890> All reviewed patches have been landed. Closing bug. |