Bug 121582

Summary:

[Lion] media/track/track-in-band-duplicate-tracks-when-source-changes.html fails

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Media

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

ahmad.saleem792, ap, b.long, eric.carlson, jer.noble

Priority:

Keywords:

LayoutTestFailure

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Skip this test on older OS X versions	none
Remove duplicate test expectation	b.long: commit-queue-

Ryosuke Niwa

Reported 2013-09-18 19:13:54 PDT

The test added by http://trac.webkit.org/changeset/154760 always fails on Lion: http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Ftrack%2Ftrack-in-band-duplicate-tracks-when-source-changes.html

Attachments
Skip this test on older OS X versions (1.67 KB, patch) 2013-09-19 10:48 PDT, Brendan Long	no flags	Details Formatted Diff Diff
Remove duplicate test expectation (2.04 KB, patch) 2013-09-19 10:58 PDT, Brendan Long	b.long: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2013-09-18 19:16:47 PDT

Added the test expectation in http://trac.webkit.org/changeset/156077.

Brendan Long

Comment 2 2013-09-19 07:45:48 PDT

Is there any way to see what the rest results are? Are in-band tracks only available on Mountain Lion or something?

Ryosuke Niwa

Comment 3 2013-09-19 10:34:49 PDT

http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r156039%20(10815)/results.html

Brendan Long

Comment 4 2013-09-19 10:48:13 PDT

Created attachment 212079 [details] Skip this test on older OS X versions It looks like in-band tracks don't work on older OS X versions. I added another line to the section that's skipping all of the other in-band track tests.

Ryosuke Niwa

Comment 5 2013-09-19 10:51:56 PDT

Comment on attachment 212079 [details] Skip this test on older OS X versions View in context: https://bugs.webkit.org/attachment.cgi?id=212079&action=review > LayoutTests/platform/mac/TestExpectations:1115 > +webkit.org/b/103663 [ MountainLion Lion SnowLeopard ] media/track/track-in-band-duplicate-tracks-when-source-changes.html Please remove test expectations added in http://trac.webkit.org/changeset/156077.

Brendan Long

Comment 6 2013-09-19 10:58:21 PDT

Created attachment 212080 [details] Remove duplicate test expectation

Brendan Long

Comment 7 2013-09-19 10:59:55 PDT

(In reply to comment #5) > Please remove test expectations added in http://trac.webkit.org/changeset/156077. Sorry, I comment #1 wrong. The duplicate test expectation is removed now.

Brendan Long

Comment 8 2013-10-01 09:38:37 PDT

Was this committed?

Alexey Proskuryakov

Comment 9 2013-10-01 12:38:18 PDT

> Was this committed? No. I don't understand this patch. Why does it add an expectation for MountainLion, does the test fail there?

Brendan Long

Comment 10 2013-10-01 12:39:55 PDT

The comment above (In reply to comment #9) > I don't understand this patch. Why does it add an expectation for MountainLion, does the test fail there? The comment above the section I added this to says: > # Mountain Lion and prior do not allow access to in-band text tracks

Alexey Proskuryakov

Comment 11 2013-10-01 12:59:45 PDT

I am asking whether the test is actually failing. We have bots for that - if you go to <http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r156726%20(13408)/results.html>, you can see that it's not reported as failing. Why is that?

Brendan Long

Comment 12 2013-10-01 13:03:28 PDT

Maybe that comment is wrong..

Brendan Long

Comment 13 2013-10-01 13:26:47 PDT

I grepped through the TestExpectations files and I don't see any reason why this would be skipped on Mountain Lion. My best guess is that the comment is wrong, but I don't have a machine with Mountain Lion on it, and I'm not sure how to confirm this in the code.

Alexey Proskuryakov

Comment 14 2013-10-01 13:51:57 PDT

I asked our media experts, and turns out that the comment is no longer accurate. We still don't have access to cues, but we know about in-band tracks now, even on Lion. It looks like the failures are timing related. It was suggested that the tests should probably be fixed to wait for 'trackchange'.

Ahmad Saleem

Comment 15 2023-10-25 13:59:51 PDT

We have platform specific expectation but tracked in newer bug 228364. https://searchfox.org/wubkat/source/LayoutTests/platform/ios-wk2/TestExpectations#1821 Marking this as duplicate to newer, would be appropriate IMO. Any input?

Note You need to log in before you can comment on or make changes to this bug.