Bug 121568

Summary: Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in WebKit and WebKit2
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, gyuyoung.kim, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+

Sam Weinig
Reported 2013-09-18 13:28:39 PDT
Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in WebKit and WebKit2
Attachments
Patch (14.95 KB, patch)
2013-09-18 13:29 PDT, Sam Weinig 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2013-09-18 13:29:34 PDT
Created attachment 212016 [details] Patch
Sam Weinig
Comment 2 2013-09-18 14:44:47 PDT
Committed r156063: <http://trac.webkit.org/changeset/156063>
Brent Fulgham
Comment 3 2013-09-18 15:25:48 PDT
Comment on attachment 212016 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212016&action=review This change breaks the Windows build. > Source/WebKit/win/WebHistory.h:150 > + std::unique<DATE[]> m_orderedLastVisitedDays; Should this have been std::unique_ptr? Isn't std::unique an algorithm?
Note You need to log in before you can comment on or make changes to this bug.