Bug 121566

Summary: REGRESSION (r129451): run-safari --no-saved-state is broken
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed fix mrowe: review+

Alexey Proskuryakov
Reported 2013-09-18 13:01:29 PDT
It looks like run-safari --no-saved-state doesn't work with some Perl versions, the argument is ignored.
Attachments
proposed fix (1.35 KB, patch)
2013-09-18 13:11 PDT, Alexey Proskuryakov 		mrowe: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2013-09-18 13:10:09 PDT
Looking at the code, I don't see how it could possibly work anywhere, I probably made a mistake in my testing. <http://trac.webkit.org/r129451> is very clearly the culprit.
Alexey Proskuryakov
Comment 2 2013-09-18 13:11:31 PDT
Created attachment 212015 [details] proposed fix
Alexey Proskuryakov
Comment 3 2013-09-18 13:30:35 PDT
Committed <http://trac.webkit.org/r156057> with an additional change to suppress AppKit warning logging.
Alexey Proskuryakov
Comment 4 2013-09-19 12:22:04 PDT
> an additional change to suppress AppKit warning logging. This didn't actually work, removed that part in r156109.
Note You need to log in before you can comment on or make changes to this bug.