Bug 121535

Summary: WinLauncher needs better url handling
Product: WebKit Reporter: Alex Christensen <alex.christensen>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: bfulgham, commit-queue
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch none

Alex Christensen
Reported 2013-09-17 21:02:07 PDT
BrowserWindowController.m has a function called addProtocolIfNecessary which prepends "http://" if "://" is not found in the url of MiniBrowser. A similar behaviour can be achieved with a simple one line change that makes it so if you type "webkit.org" into WinLauncher you'll get to your favourite website instead of having to type "http://www.webkit.org/". Also, we defined our own macro MAX_URL_LENGTH which is 1024 instead of INTERNET_MAX_URL_LENGTH from WinInet.h which is 2083. This should be consistent. This makes WinLauncher more stable and user friendly.
Attachments
Patch (1.82 KB, patch)
2013-09-17 21:05 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2013-09-17 21:05:31 PDT
Created attachment 211969 [details] Patch
Brent Fulgham
Comment 2 2013-09-17 21:55:43 PDT
Comment on attachment 211969 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211969&action=review R=me > Tools/WinLauncher/WinLauncher.cpp:-875 > - Good!
WebKit Commit Bot
Comment 3 2013-09-18 10:20:53 PDT
Comment on attachment 211969 [details] Patch Clearing flags on attachment: 211969 Committed r156048: <http://trac.webkit.org/changeset/156048>
WebKit Commit Bot
Comment 4 2013-09-18 10:20:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.