Bug 121521

Summary:

run-jsc-stress-tests fails with ruby version 2

Product:

WebKit

Reporter:

Michael Saboff <msaboff>

Component:

Tools / Tests

Assignee:

Michael Saboff <msaboff>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

InRadar

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	jberlin: review+

Description Michael Saboff 2013-09-17 14:29:36 PDT

When running run-javascriptcore-tests with ruby version 2 installed, we get this error:

Error: #<LoadError: cannot load such file -- highline>
Tools/Scripts/run-jsc-stress-tests:330:in `block (4 levels) in <main>': invalid byte sequence in US-ASCII (ArgumentError)
	from Tools/Scripts/run-jsc-stress-tests:328:in `each_line'
	from Tools/Scripts/run-jsc-stress-tests:328:in `block (3 levels) in <main>'
	from Tools/Scripts/run-jsc-stress-tests:326:in `open'
	from Tools/Scripts/run-jsc-stress-tests:326:in `block (2 levels) in <main>'
	from Tools/Scripts/run-jsc-stress-tests:320:in `each'
	from Tools/Scripts/run-jsc-stress-tests:320:in `block in <main>'
	from Tools/Scripts/run-jsc-stress-tests:286:in `each'
	from Tools/Scripts/run-jsc-stress-tests:286:in `<main>'

<rdar://problem/15010705>

Comment 1 Michael Saboff 2013-09-17 14:36:26 PDT

Created attachment 211944 [details]
Patch

It appears that ruby version 2 uses the LANG environment variable to figure what character set to use when reading a file.  Setting to a UTF8 language makes ruby happy.

Comment 2 Michael Saboff 2013-09-17 14:43:45 PDT

Committed r155999: <http://trac.webkit.org/changeset/155999>