Bug 121520

Summary:

DFG should use the (x & 0x7fffffff) trick for doing overflow and neg-zero checks on negation in one go

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	oliver: review+

Description Filip Pizlo 2013-09-17 14:26:31 PDT

The baseline JIT uses it already.  It's a silly oversight that the DFG doesn't.

Comment 1 Filip Pizlo 2013-09-17 14:27:18 PDT

Created attachment 211942 [details]
the patch

Comment 2 Filip Pizlo 2013-09-17 18:03:50 PDT

Landed in http://trac.webkit.org/changeset/156016